Merged
Conversation
Enables on-demand package publishing to PyPI through GitHub Actions workflow dispatch. Accepts configurable git tag and Python version inputs, builds source distribution with CUDA build skipped, and uploads to PyPI using API token authentication. Includes validation to prevent publishing when required secrets are missing.
github-actions
bot
requested review from
Evanwu1125,
SNHuan,
Thanksyy,
ftgreat,
juliohsu,
wubingheng111 and
zacliu2023
github-actions
bot
assigned
Evanwu1125,
ftgreat,
juliohsu,
SNHuan,
Thanksyy,
wubingheng111 and
zacliu2023
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a manually triggered GitHub Actions workflow for publishing packages to PyPI with configurable inputs for git tags and Python versions. The workflow includes validation to ensure required secrets are present before attempting to publish.
- Introduces
manual_publish.ymlworkflow withworkflow_dispatchtrigger for on-demand execution - Implements input validation for git tag selection and Python version configuration
- Includes secret validation to prevent publishing attempts without proper authentication
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+51
to
+53
| if [ -z "$TWINE_PASSWORD" ]; then | ||
| echo "::error::PYPI_API_TOKEN secret not set; aborting publish."; exit 1 | ||
| fi |
There was a problem hiding this comment.
[nitpick] The secret validation logic should be moved to an earlier step to fail fast before performing expensive build operations. Consider adding a separate validation step before the build step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a GitHub Actions workflow for on-demand package publishing to PyPI, allowing configurable git tag and Python version inputs. Implement validation to prevent publishing without required secrets.