[BUG FIX] Refactor block min/max calculations#223
Merged
LoserCheems merged 2 commits intomainfrom Jan 19, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors block min/max calculations in Triton kernels to use Triton's native tl.minimum and tl.maximum functions instead of Python's built-in min and max functions, improving performance within the Triton compilation context.
Changes:
- Replaced all instances of Python's
min/maxwithtl.minimum/tl.maximumin block calculation functions - Applied changes consistently across all four Triton JIT-compiled functions in the file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Improves masking flexibility by supporting seqlen, causal, and local windows while guarding unsupported configurations for swapped dimensions and packed GQA.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
Changes
Reproduction
Tests
Compatibility
Checklist