Add utility functions for device management and input validation#225
Merged
LoserCheems merged 7 commits intomainfrom Feb 8, 2026
Merged
Add utility functions for device management and input validation#225LoserCheems merged 7 commits intomainfrom
LoserCheems merged 7 commits intomainfrom
Conversation
…s input handling for improved clarity and consistency
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces utility functions for device management, input validation, and autotuning configuration to support a Triton-based multi-platform attention implementation (related to issue #222). The changes split the monolithic _flash_attn_forward function into separate base and varlen variants while extracting common utilities.
Changes:
- Added a new
utils.pymodule with device detection, architecture retrieval, autotuning configuration generation, and input validation functions - Refactored
flash_fwd.pyto use the new utility functions and split the forward pass into_flash_attn_base_forwardand_flash_attn_varlen_base_forwardfunctions - Enabled CUDA graph support in the autotune decorator
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 15 comments.
| File | Description |
|---|---|
| flash_sparse_attn/ops/triton/utils.py | New utility module providing device detection, architecture identification, autotuning configuration, grid generation, and input validation functions |
| flash_sparse_attn/ops/triton/flash_fwd.py | Refactored to use new utilities, split forward pass into separate base and varlen functions, and enabled CUDA graph support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…on to use triton utility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
Changes
Reproduction
Tests
Compatibility
Checklist