Conversation
…use base addresses Co-authored-by: HMBSbige <19153265+HMBSbige@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Replace MemoryMarshal.GetReference with GetReference extension
Replace MemoryMarshal.GetReference with GetReference extension and reuse base addresses
Oct 27, 2025
Owner
|
@copilot 无法复用的不要局部变量 |
Co-authored-by: HMBSbige <19153265+HMBSbige@users.noreply.github.com>
Contributor
Author
Removed unnecessary local variables where base address is only used once. Now variables are only created when the base address is reused multiple times (commit 7d49d82). Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
HMBSbige
requested changes
Oct 27, 2025
| { | ||
| ref uint counter = ref Unsafe.Add(ref MemoryMarshal.GetReference(state), 12); | ||
| ref uint stateRef = ref state.GetReference(); | ||
| ref uint counter = ref Unsafe.Add(ref stateRef, 12); |
Contributor
Author
There was a problem hiding this comment.
Removed the unnecessary stateRef variable (commit 6dc1736).
Co-authored-by: HMBSbige <19153265+HMBSbige@users.noreply.github.com>
HMBSbige
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace MemoryMarshal.GetReference with GetReference extension and reuse computed base addresses
Pattern applied:
Unsafe.AddGetReference()is called directly inline without intermediate variableOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.