Change ref parameters to ref readonly for read-only cases #99
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several methods pass parameters by
refwhen they're only read, not modified. This obscures intent and prevents potential compiler optimizations.Changes
MultiplyR(ref Vector128<uint> h01, h23, h44, ...)→ref readonlyfor the three input vectors used only in multiplication operationsStep(ref uint a, ref uint b, ref uint c, ...)→ref readonly uint bas it's only used ina += bExample
Note:
BroadcastVector128ToVector256cannot useref readonlyasUnsafe.AsPointerrequires mutable references even for read-only operations.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.