Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the mod management search functionality to support searching across multiple mod properties instead of just the filename. The search now includes mod name, version, game version, ID, mod loader type, and display name.
- Enhanced search predicate to handle nullable strings safely
- Extended search criteria to include multiple mod properties (name, version, game version, ID, mod loader type, display name)
- Added null-safety checks for regex and string matching operations
HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModListPageSkin.java
Outdated
Show resolved
Hide resolved
HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModListPageSkin.java
Outdated
Show resolved
Hide resolved
Glavo
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.