Skip to content

Fix #4063: 修复游戏版本列表去重问题 #4066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Glavo merged 3 commits into from
Jul 26, 2025
Merged

Fix #4063: 修复游戏版本列表去重问题 #4066

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ce69c6
Fix #4063: 修复游戏版本列表去重问题
Wulian233 Jul 5, 2025
b18d719
用GameVersion比较
Wulian233 Jul 5, 2025
d948354
ok~
Wulian233 Jul 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion HMCLCore/src/main/java/org/jackhuang/hmcl/download/game/GameRemoteVersion.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import org.jackhuang.hmcl.game.Version;
import org.jackhuang.hmcl.task.Task;
import org.jackhuang.hmcl.util.Immutable;
import org.jackhuang.hmcl.util.versioning.GameVersionNumber;

import java.time.Instant;
import java.util.List;
Expand Down Expand Up @@ -56,7 +57,12 @@ public int compareTo(RemoteVersion o) {
if (!(o instanceof GameRemoteVersion))
return 0;

return o.getReleaseDate().compareTo(getReleaseDate());
int dateCompare = o.getReleaseDate().compareTo(getReleaseDate());
if (dateCompare != 0) {
return dateCompare;
}

return GameVersionNumber.compare(getSelfVersion(), o.getSelfVersion());
Comment on lines +60 to +65
Copy link

Copilot AI Jul 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method call o.getSelfVersion() assumes that the cast to GameRemoteVersion is safe, but the type check only verifies instanceof GameRemoteVersion. If o is not actually a GameRemoteVersion, this will cause a ClassCastException. Consider casting o to GameRemoteVersion explicitly after the instanceof check.

Suggested change
int dateCompare = o.getReleaseDate().compareTo(getReleaseDate());
if (dateCompare != 0) {
return dateCompare;
}
return GameVersionNumber.compare(getSelfVersion(), o.getSelfVersion());
GameRemoteVersion gameRemoteVersion = (GameRemoteVersion) o;
int dateCompare = gameRemoteVersion.getReleaseDate().compareTo(getReleaseDate());
if (dateCompare != 0) {
return dateCompare;
}
return GameVersionNumber.compare(getSelfVersion(), gameRemoteVersion.getSelfVersion());

Copilot uses AI. Check for mistakes.
}

private static Type getReleaseType(ReleaseType type) {
Expand Down