优化微软登录页面 by CiiLu · Pull Request #4794 · HMCL-dev/HMCL

CiiLu · 2025-11-15T14:35:49Z

TODO:i18n

简化文字描述（一大串容易让用户直接无视）
突出显示失败原因（用户群经常有人看不到错误信息）
突出显示代码
获取到代码后 3 秒再弹出网页（之前弹出的太快很容易看不到有代码出现）
下面的一串超链接改为于HintPane中显示

优化前	优化后

CiiLu · 2025-11-21T14:08:59Z

cc @3gf8jv4dv

3gf8jv4dv · 2025-11-22T03:54:48Z

I will take a look later.

3gf8jv4dv

👍👍👍

可以先把另外两份 i18n 同步下，然后我审一下。

HMCL/src/main/resources/assets/lang/I18N.properties

HMCL/src/main/resources/assets/lang/I18N_zh.properties

HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties

Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>

Glavo · 2025-12-03T12:30:15Z

HMCL/src/main/java/org/jackhuang/hmcl/game/OAuthServer.java

            lastlyOpenedURL = url;
+
+            try {
+                Thread.sleep(3000);


感觉强制等待三秒会影响到了解登陆流程的用户的使用体验，可能需要更好的逻辑来改善用户体验。

这个实际上问题不大，登录微软账户也不是什么需要频繁进行的操作

这个实际上问题不大，登录微软账户也不是什么需要频繁进行的操作

我使用的时候对这个硬控三秒感到很烦躁。至少对我个人来说，这个非常影响使用体验。

这个实际上问题不大，登录微软账户也不是什么需要频繁进行的操作

我使用的时候对这个硬控三秒感到很烦躁。至少对我个人来说，这个非常影响使用体验。

实际上其他启动器也是类似的逻辑。如果你依然认为有必要更改，可以直接缩短此处的时间。

可以把等待时间改短一点。我觉得 1s 或 2s 应该够了。

Copilot

Pull request overview

This pull request optimizes the Microsoft login page UI/UX with several improvements to make the authentication process clearer and more user-friendly. The changes simplify text descriptions, highlight error messages and authentication codes, add a 3-second delay before opening the browser to ensure users see the code, and reorganize hyperlinks to show them only when needed.

Key Changes

Simplified and reorganized i18n strings for Microsoft login flow across all language files (Chinese Simplified, Chinese Traditional, and English)
Refactored CreateAccountPane.java to display the authentication code more prominently with better error message handling
Added a 3-second delay in OAuthServer.java before opening the browser to give users time to see the code
Updated hyperlink handling to use setExternalLink() method for cleaner code

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties	Updated Simplified Chinese strings for Microsoft login, simplified instructions, added HTML links in error messages, and added new code display label
HMCL/src/main/resources/assets/lang/I18N_zh.properties	Updated Traditional Chinese strings for Microsoft login with simplified instructions and HTML links (contains bugs in URL and direction text)
HMCL/src/main/resources/assets/lang/I18N.properties	Updated English strings for Microsoft login with clearer, more concise instructions and embedded hyperlinks
HMCL/src/main/java/org/jackhuang/hmcl/ui/account/OAuthAccountLoginDialog.java	Refactored to use `setExternalLink()` method for hyperlinks instead of manual event handlers
HMCL/src/main/java/org/jackhuang/hmcl/ui/account/CreateAccountPane.java	Completely refactored Microsoft login UI with prominent code display, better error handling, and conditional visibility for different UI elements
HMCL/src/main/java/org/jackhuang/hmcl/setting/Accounts.java	Updated error message key to use unified `add_family` message
HMCL/src/main/java/org/jackhuang/hmcl/game/OAuthServer.java	Added 3-second delay before opening browser to allow users to see the authentication code

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-03T12:47:21Z

HMCL/src/main/java/org/jackhuang/hmcl/ui/account/CreateAccountPane.java

+                    runInFX(() -> deviceCode.set(value))
+            ));
+
+            HBox linkBox = new HBox();


[nitpick] The HBox linkBox is created without spacing between hyperlinks. The previous code used FlowPane with setHgap(8) to provide spacing. Consider setting spacing for the HBox: HBox linkBox = new HBox(8); to maintain visual consistency.

Suggested change

HBox linkBox = new HBox();

HBox linkBox = new HBox(8);

Copilot · 2025-12-03T12:47:22Z

HMCL/src/main/java/org/jackhuang/hmcl/ui/account/CreateAccountPane.java

+            Label hint = new Label(i18n("account.methods.microsoft.code"));
+            Label code = new Label();
+            code.setMouseTransparent(true);
+            code.setStyle("-fx-font-size: 24");


[nitpick] The font size is set using an inline style string ("-fx-font-size: 24"). This could cause inconsistency with the application's theme. Consider defining a CSS class for the code display or using the theme's font sizes for consistency.

Suggested change

code.setStyle("-fx-font-size: 24");

code.getStyleClass().add("microsoft-device-code");

HMCL/src/main/resources/assets/lang/I18N_zh.properties

Copilot · 2025-12-03T12:47:22Z

HMCL/src/main/java/org/jackhuang/hmcl/game/OAuthServer.java

+            try {
+                Thread.sleep(3000);
+            } catch (InterruptedException ignored) {
+            }


Using Thread.sleep() blocks the calling thread for 3 seconds. If this method is called on the UI thread or a thread from a limited thread pool, it could cause unresponsiveness or performance issues. Consider using a scheduled executor or asynchronous delay (e.g., CompletableFuture.delayedExecutor() or JavaFX PauseTransition) instead of blocking the thread.

HMCL/src/main/resources/assets/lang/I18N_zh.properties

Copilot · 2025-12-03T12:47:23Z

HMCL/src/main/java/org/jackhuang/hmcl/ui/account/CreateAccountPane.java

+            if (Accounts.OAUTH_CALLBACK.getClientId().isEmpty()) {
                HintPane hintPane = new HintPane(MessageDialogPane.MessageType.WARNING);
                hintPane.setSegment(i18n("account.methods.microsoft.snapshot"));
+                vbox.getChildren().add(hintPane);


After the early return on line 295, the detailsPane is never added to detailsContainer. The detailsContainer.getChildren().add(detailsPane) call on line 373 is unreachable for this code path. Consider adding detailsContainer.getChildren().add(detailsPane); before the return statement on line 295.

Suggested change

vbox.getChildren().add(hintPane);

vbox.getChildren().add(hintPane);

detailsContainer.getChildren().add(detailsPane);

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Glavo

请更新所有语言文件。如果你不会其中的一些语言，那么请删除这些文件中过时的译文，让它们回退到英语，而不是保留这些过时译文。

burningtnt · 2026-01-01T10:03:49Z

优化后的效果很不错。

CiiLu added 2 commits November 15, 2025 22:24

update

51b2592

update

be5b6e5

CiiLu and others added 2 commits November 22, 2025 11:57

Merge branch 'HMCL-dev:main' into soms

8f70501

wip

116f3f9

3gf8jv4dv reviewed Nov 22, 2025

View reviewed changes

CiiLu added 2 commits November 29, 2025 19:16

update

261deaa

update

3a10ded

CiiLu requested a review from 3gf8jv4dv November 29, 2025 13:26

Merge branch 'main' into soms

f1f849a

3gf8jv4dv suggested changes Nov 29, 2025

View reviewed changes

CiiLu and others added 3 commits November 30, 2025 08:11

Apply suggestions from code review

9bc23ed

Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>

Update I18N.properties

29db118

Update I18N_zh.properties

a97f659

CiiLu requested a review from 3gf8jv4dv November 30, 2025 00:16

Glavo reviewed Dec 3, 2025

View reviewed changes

Glavo requested review from Copilot and removed request for 3gf8jv4dv December 3, 2025 12:39

Copilot started reviewing on behalf of Glavo December 3, 2025 12:40 View session

Copilot finished reviewing on behalf of Glavo December 3, 2025 12:43

Copilot AI reviewed Dec 3, 2025

View reviewed changes

CiiLu and others added 3 commits December 5, 2025 22:55

Update HMCL/src/main/resources/assets/lang/I18N_zh.properties

80d6abe

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update HMCL/src/main/resources/assets/lang/I18N_zh.properties

101f342

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Merge branch 'HMCL-dev:main' into soms

894bc65

Glavo reviewed Dec 24, 2025

View reviewed changes

update

80e0b24

burningtnt requested a review from Glavo January 1, 2026 10:03

Update OAuthServer.java

38f5f44

Glavo merged commit 2e4cc76 into HMCL-dev:main Jan 2, 2026
2 checks passed

CiiLu deleted the soms branch January 2, 2026 14:15

	code.setStyle("-fx-font-size: 24");
	code.getStyleClass().add("microsoft-device-code");

	vbox.getChildren().add(hintPane);
	vbox.getChildren().add(hintPane);
	detailsContainer.getChildren().add(detailsPane);

Conversation

CiiLu commented Nov 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CiiLu commented Nov 21, 2025

Uh oh!

3gf8jv4dv commented Nov 22, 2025

Uh oh!

3gf8jv4dv left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Glavo Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

burningtnt Dec 6, 2025

Choose a reason for hiding this comment

Uh oh!

Glavo Dec 6, 2025

Choose a reason for hiding this comment

Uh oh!

burningtnt Dec 6, 2025

Choose a reason for hiding this comment

Uh oh!

3gf8jv4dv Dec 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Glavo left a comment

Choose a reason for hiding this comment

Uh oh!

burningtnt commented Jan 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

CiiLu commented Nov 15, 2025 •

edited

Loading