Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the color scheme of the update notification popup (bubble) by migrating from hardcoded colors to Material Design 3 Monet theme variables. The changes ensure consistent theming across different color schemes and improve maintainability.
Key changes:
- Replaced hardcoded colors in the update bubble with theme-aware Monet color variables
- Added support for transparent inverse surface color (80% opacity) across the theming system
- Simplified code by removing an unnecessary intermediate Label variable in MainPage
- Updated UpgradeDialog to use JFXSpinner instead of ProgressIndicator for better theme consistency
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| HMCL/src/main/resources/assets/css/root.css | Updated .bubble styles and .html-hyperlink to use Monet color variables instead of hardcoded colors (black, white, blue) |
| HMCL/src/main/resources/assets/css/blue.css | Added -monet-inverse-surface-transparent-80 color definition for the default blue theme |
| HMCL/src/main/java/org/jackhuang/hmcl/ui/main/MainPage.java | Removed unnecessary intermediate Label variable, directly using SVG icon in HBox |
| HMCL/src/main/java/org/jackhuang/hmcl/ui/UpgradeDialog.java | Replaced ProgressIndicator with JFXSpinner and updated import statements |
| HMCL/src/main/java/org/jackhuang/hmcl/setting/StyleSheets.java | Added generation of INVERSE_SURFACE color with 80% opacity for dynamic theme stylesheets |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.