Fix #4900: 修复 ManagedProcess#getLines 完成后不会解除锁定的问题 #4913
Merged
Glavo merged 2 commits intoHMCL-dev:mainfrom Dec 3, 2025
Merged
Fix #4900: 修复 ManagedProcess#getLines 完成后不会解除锁定的问题 #4913Glavo merged 2 commits intoHMCL-dev:mainfrom
Glavo merged 2 commits intoHMCL-dev:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical concurrency bug in the ManagedProcess#getLines method where the ReentrantLock was acquired but never released, potentially causing deadlocks when multiple threads access this method.
- Wraps the
getLinesmethod logic in a try-finally block to ensure the lock is properly released
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Glavo
added a commit
to Glavo/HMCL
that referenced
this pull request
Dec 14, 2025
Glavo
added a commit
that referenced
this pull request
Dec 18, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.