feat: Legacy Fabric 自动安装 #5090

CiiLu · 2025-12-28T03:02:03Z

相关 [Feature] 为旧版 MC 添加 Ornithe（或者同类）模组加载器选项 #5007

HMCL/src/main/java/org/jackhuang/hmcl/ui/construct/TaskListPane.java

HMCL/src/main/java/org/jackhuang/hmcl/ui/download/InstallersPage.java

HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModListPageSkin.java

HMCL/src/main/java/org/jackhuang/hmcl/ui/InstallerItem.java

HMCLCore/src/main/java/org/jackhuang/hmcl/download/legacyfabric/LegacyFabricInstallTask.java

HMCLCore/src/main/java/org/jackhuang/hmcl/download/BMCLAPIDownloadProvider.java

Copilot

Pull request overview

This pull request adds automatic installation support for Legacy Fabric, a mod loader for older Minecraft versions (1.13.2 and below). The implementation follows the same patterns used for Fabric and Quilt mod loaders.

Key Changes

Added LEGACY_FABRIC enum value to ModLoaderType and corresponding library types in LibraryAnalyzer
Created new package org.jackhuang.hmcl.download.legacyfabric with version lists, install tasks, and API support
Updated download providers (MojangDownloadProvider and BMCLAPIDownloadProvider) to include Legacy Fabric support
Added localization strings and icons for Legacy Fabric across multiple languages
Updated UI components to display and handle Legacy Fabric installations
Modified switch statements from old-style to switch expressions while adding Legacy Fabric cases

Reviewed changes

Copilot reviewed 29 out of 31 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
ModLoaderType.java	Added LEGACY_FABRIC enum value
LibraryAnalyzer.java	Added LEGACY_FABRIC and LEGACY_FABRIC_API library types with detection logic
LegacyFabricVersionList.java	New file implementing version list for Legacy Fabric loader
LegacyFabricRemoteVersion.java	New file defining remote version for Legacy Fabric
LegacyFabricInstallTask.java	New file implementing installation task for Legacy Fabric
LegacyFabricAPIVersionList.java	New file implementing version list for Legacy Fabric API
LegacyFabricAPIRemoteVersion.java	New file defining remote version for Legacy Fabric API
LegacyFabricAPIInstallTask.java	New file implementing installation task for Legacy Fabric API
MojangDownloadProvider.java	Added Legacy Fabric version lists and updated switch to expression
BMCLAPIDownloadProvider.java	Added Legacy Fabric version lists and updated switch to expression
DefaultLauncher.java	Added INST_LEGACYFABRIC environment variable
McbbsModpackExportTask.java	Added Legacy Fabric support for modpack export
FabricInstallTask.java	Added @JsonSerializable annotations for Gson classes
QuiltInstallTask.java	Added @JsonSerializable annotations for Gson classes
FabricAPIInstallTask.java	Refactored to use getModsDirectory() method
QuiltAPIInstallTask.java	Refactored to use getModsDirectory() method
I18N*.properties	Added localization strings for Legacy Fabric in English, Chinese, and Traditional Chinese
legacyfabric.png / [email protected]	Added icon images for Legacy Fabric
VersionIconType.java	Added LEGACY_FABRIC icon type
VersionIconDialog.java	Added Legacy Fabric icon to version icon selection
ModListPageSkin.java	Updated switch statements and added Legacy Fabric case
ModListPage.java	Added Legacy Fabric to supported loaders (supports Fabric mods)
InstallerListPage.java	Updated filter logic to exclude all API installers using endsWith
VersionsPage.java	Added icon mapping for Legacy Fabric versions
InstallersPage.java	Added Legacy Fabric case with underscore replacement
TaskListPane.java	Added Legacy Fabric install task naming and stage handling
InstallerItem.java	Added Legacy Fabric items and incompatibility rules
HMCLGameRepository.java	Added Legacy Fabric icon detection for version display

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-07T14:43:07Z

HMCL/src/main/java/org/jackhuang/hmcl/ui/InstallerItem.java

+            mutualIncompatible(incompatibleMap, forge, fabric, quilt, neoForge, cleanroom, legacyfabric);
+            addIncompatibles(incompatibleMap, liteLoader, fabric, quilt, neoForge, cleanroom, legacyfabric);
+            addIncompatibles(incompatibleMap, optiFine, fabric, quilt, neoForge, cleanroom, liteLoader, legacyfabric);
+            addIncompatibles(incompatibleMap, fabricApi, forge, quiltApi, neoForge, liteLoader, optiFine, cleanroom, legacyfabricApi, legacyfabricApi);


The fabricApi incompatibility list has 'legacyfabricApi' duplicated. The second occurrence should be 'legacyfabric' instead, so that fabricApi is marked as incompatible with both the Legacy Fabric loader and Legacy Fabric API.

Suggested change

addIncompatibles(incompatibleMap, fabricApi, forge, quiltApi, neoForge, liteLoader, optiFine, cleanroom, legacyfabricApi, legacyfabricApi);

addIncompatibles(incompatibleMap, fabricApi, forge, quiltApi, neoForge, liteLoader, optiFine, cleanroom, legacyfabricApi, legacyfabric);

Copilot · 2026-01-07T14:43:08Z

HMCLCore/src/main/java/org/jackhuang/hmcl/download/legacyfabric/LegacyFabricAPIInstallTask.java

@@ -0,0 +1,61 @@
+/*
+ * Hello Minecraft! Launcher
+ * Copyright (C) 2021  huangyuhui <[email protected]> and contributors


Inconsistent copyright year. The copyright year is '2021' but other files in the same package use '2022'. For consistency, this should be updated to match.

Copilot · 2026-01-07T14:43:08Z

HMCL/src/main/java/org/jackhuang/hmcl/ui/download/InstallersPage.java

+                    case FORGE -> loaderName = i18n("install.installer.forge");
+                    case NEO_FORGE -> loaderName = i18n("install.installer.neoforge");
+                    case CLEANROOM -> loaderName = i18n("install.installer.cleanroom");
+                    case LEGACY_FABRIC -> loaderName = i18n("install.installer.legacyfabric").replace(" ", "_");


The replacement of spaces with underscores only for Legacy Fabric seems inconsistent with how other loaders are named. This special handling should be documented or the naming convention should be consistent across all loaders.

Copilot · 2026-01-07T14:43:09Z

HMCLCore/src/main/java/org/jackhuang/hmcl/mod/mcbbs/McbbsModpackExportTask.java

                    addons.add(new McbbsModpackManifest.Addon(FABRIC.getPatchId(), fabricVersion)));
            analyzer.getVersion(QUILT).ifPresent(quiltVersion ->
                    addons.add(new McbbsModpackManifest.Addon(QUILT.getPatchId(), quiltVersion)));
+            analyzer.getVersion(LEGACY_FABRIC).ifPresent(quiltVersion ->


Variable name should be 'legacyFabricVersion' instead of 'quiltVersion'. This is a copy-paste error from the Quilt code above.

Copilot · 2026-01-07T14:43:09Z

HMCLCore/src/main/java/org/jackhuang/hmcl/mod/ModLoaderType.java

    LITE_LOADER,
-    PACK;
+    LEGACY_FABRIC,
+    PACK


Missing semicolon at the end of the enum. The semicolon should be placed after 'PACK' on line 29.

Suggested change

PACK

PACK;

Copilot · 2026-01-07T14:43:09Z

HMCLCore/src/main/java/org/jackhuang/hmcl/download/LibraryAnalyzer.java

+                return true;
+            }
+        },
+        FABRIC_API(true, "fabric-api", "net.fabricmc", "fabric-api", null),FORGE(true, "forge", "net\\.minecraftforge", "(forge|fmlloader)", ModLoaderType.FORGE) {


Missing space after comma. There should be a space between 'FABRIC_API(true, "fabric-api", "net.fabricmc", "fabric-api", null),' and 'FORGE(...)' to maintain consistent formatting.

Suggested change

FABRIC_API(true, "fabric-api", "net.fabricmc", "fabric-api", null),FORGE(true, "forge", "net\\.minecraftforge", "(forge|fmlloader)", ModLoaderType.FORGE) {

FABRIC_API(true, "fabric-api", "net.fabricmc", "fabric-api", null), FORGE(true, "forge", "net\\.minecraftforge", "(forge|fmlloader)", ModLoaderType.FORGE) {

HMCLCore/src/main/java/org/jackhuang/hmcl/download/LibraryAnalyzer.java

CiiLu added 3 commits December 28, 2025 10:38

Legacy Fabric

92dfbf7

update

07320a4

update

ff66c0f

burningtnt suggested changes Dec 28, 2025

View reviewed changes

update

829c918

Glavo requested a review from Copilot January 7, 2026 14:38

Copilot started reviewing on behalf of Glavo January 7, 2026 14:38 View session

Copilot AI reviewed Jan 7, 2026

View reviewed changes

Glavo added 4 commits January 7, 2026 22:45

update

f804625

update

547f216

update

1482b33

update

87a39e5

Glavo reviewed Jan 7, 2026

View reviewed changes

HMCLCore/src/main/java/org/jackhuang/hmcl/download/LibraryAnalyzer.java Outdated Show resolved Hide resolved

HMCLCore/src/main/java/org/jackhuang/hmcl/download/LibraryAnalyzer.java Outdated Show resolved Hide resolved

CiiLu added 2 commits January 8, 2026 21:38

update

da70d35

Merge remote-tracking branch 'origin/legacyfabric' into legacyfabric

8e17272

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Legacy Fabric 自动安装 #5090

feat: Legacy Fabric 自动安装 #5090

Uh oh!

CiiLu commented Dec 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 7, 2026

Uh oh!

Copilot AI Jan 7, 2026

Uh oh!

Copilot AI Jan 7, 2026

Uh oh!

Copilot AI Jan 7, 2026

Uh oh!

Copilot AI Jan 7, 2026

Uh oh!

Copilot AI Jan 7, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	addIncompatibles(incompatibleMap, fabricApi, forge, quiltApi, neoForge, liteLoader, optiFine, cleanroom, legacyfabricApi, legacyfabricApi);
	addIncompatibles(incompatibleMap, fabricApi, forge, quiltApi, neoForge, liteLoader, optiFine, cleanroom, legacyfabricApi, legacyfabric);

	FABRIC_API(true, "fabric-api", "net.fabricmc", "fabric-api", null),FORGE(true, "forge", "net\\.minecraftforge", "(forge\|fmlloader)", ModLoaderType.FORGE) {
	FABRIC_API(true, "fabric-api", "net.fabricmc", "fabric-api", null), FORGE(true, "forge", "net\\.minecraftforge", "(forge\|fmlloader)", ModLoaderType.FORGE) {

feat: Legacy Fabric 自动安装 #5090

Are you sure you want to change the base?

feat: Legacy Fabric 自动安装 #5090

Uh oh!

Conversation

CiiLu commented Dec 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants