Merged
Conversation
Glavo
reviewed
Jan 1, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes normalization issues for certain Minecraft game versions by adding support for lowercase variants and correcting capitalization.
- Adds lowercase variant aliases for 1.18 experimental snapshots 2-7
- Adds support for the previously missing 1.18 experimental snapshot 7
- Corrects the capitalization of version
22w13oneBlockAtATimein the versions list
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| HMCLCore/src/test/java/org/jackhuang/hmcl/util/versioning/GameVersionNumberTest.java | Updated test cases to verify normalization of lowercase experimental snapshot names (2-7) and added test for 22w13oneblockatatime variant |
| HMCLCore/src/main/resources/assets/game/versions.txt | Corrected capitalization from 22w13oneblockatatime to 22w13oneBlockAtATime |
| HMCLCore/src/main/resources/assets/game/version-alias.csv | Added lowercase variant aliases for experimental snapshots 1-7 and added alias mapping for 22w13oneBlockAtATime |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Glavo
approved these changes
Jan 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.