Merged
Conversation
Glavo
force-pushed
the
mapped-list
branch
2 times, most recently
from
793db26 to
c695c00
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR rewrites the MappedObservableList class to extend JavaFX's TransformationList instead of using a custom listener-based synchronization mechanism. This modernizes the implementation to align with standard JavaFX transformation list patterns.
Changes:
- Refactored
MappedObservableListto extendTransformationList<E, F>instead of using a separate synchronized list - Updated copyright year from 2020 to 2026
- Changed documentation style from
/** */to///to match newer codebase conventions - Added comprehensive test suite covering all list operations (add, remove, set, sort, permutation, update)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| HMCLCore/src/main/java/org/jackhuang/hmcl/util/javafx/MappedObservableList.java | Rewritten to extend TransformationList, providing a cleaner implementation that properly handles all list change types (permutation, update, add, remove) while maintaining API compatibility |
| HMCLCore/src/test/java/org/jackhuang/hmcl/util/javafx/MappedObservableListTest.java | New comprehensive test suite with 12 test methods covering initial mapping, modifications, permutations, and edge cases |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.