Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes inconsistent loading styles in management pages by refactoring ResourcepackListPage to use the standardized ToolbarListPageSkin base class, ensuring that only the ListView displays loading indicators rather than the entire page.
Changes:
- Refactored ResourcepackListPage to extend ToolbarListPageSkin instead of implementing a custom skin
- Modified ToolbarListPageSkin's hierarchy to wrap only the ListView with SpinnerPane, keeping the toolbar always visible during loading
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ResourcepackListPage.java | Refactored custom skin implementation to extend ToolbarListPageSkin, reducing code duplication and aligning with other management pages |
| ToolbarListPageSkin.java | Restructured component hierarchy so SpinnerPane wraps only the ListView instead of the entire page, unifying loading behavior across all pages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Glavo
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
原先模组、资源包管理为刷新时只有
ListView加载世界、原理图管理为整个页面加载,感觉不太统一
本 PR 将这些地方统一为了只有
ListView加载