Skip to content

修复管理页面加载样式不统一的问题#5406

Merged
Glavo merged 4 commits intoHMCL-dev:mainfrom
CiiLu:mc
Feb 6, 2026
Merged

修复管理页面加载样式不统一的问题#5406
Glavo merged 4 commits intoHMCL-dev:mainfrom
CiiLu:mc

Conversation

@CiiLu
Copy link
Contributor

@CiiLu CiiLu commented Feb 3, 2026

image

原先模组、资源包管理为刷新时只有 ListView 加载
世界、原理图管理为整个页面加载,感觉不太统一

本 PR 将这些地方统一为了只有 ListView 加载

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes inconsistent loading styles in management pages by refactoring ResourcepackListPage to use the standardized ToolbarListPageSkin base class, ensuring that only the ListView displays loading indicators rather than the entire page.

Changes:

  • Refactored ResourcepackListPage to extend ToolbarListPageSkin instead of implementing a custom skin
  • Modified ToolbarListPageSkin's hierarchy to wrap only the ListView with SpinnerPane, keeping the toolbar always visible during loading

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
ResourcepackListPage.java Refactored custom skin implementation to extend ToolbarListPageSkin, reducing code duplication and aligning with other management pages
ToolbarListPageSkin.java Restructured component hierarchy so SpinnerPane wraps only the ListView instead of the entire page, unifying loading behavior across all pages

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Glavo Glavo merged commit ef5849e into HMCL-dev:main Feb 6, 2026
8 checks passed
@CiiLu CiiLu deleted the mc branch February 12, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants