fix(i18n): clean up text for toolbar and related functions#5409
Merged
Glavo merged 1 commit intoHMCL-dev:mainfrom Feb 4, 2026
Merged
fix(i18n): clean up text for toolbar and related functions#5409Glavo merged 1 commit intoHMCL-dev:mainfrom
Glavo merged 1 commit intoHMCL-dev:mainfrom
Conversation
- Unity text style for English. - Clean up outdated text in other inactive and unmaintained languages. - Organize all variants of Chinese text.
be41186 to
7d3360c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines i18n/UI text for instance management toolbars and related dialogs, standardizing concise English labels, consolidating extension descriptions, and aligning world/import wording across pages. It also trims or adjusts outdated strings in less-maintained locales while preserving functional behavior.
Changes:
- Introduced shared
extension.*labels (mod, datapack, resourcepack, schematic, world, modloader installer) and wired them into file choosers for mods, datapacks, resource packs, schematics, and worlds. - Simplified and unified toolbar and dialog texts (e.g., “Add”, “Download”) for Java management, mods, worlds, datapacks, resource packs, schematics, and world import errors, including new
*.add.titlekeys for chooser titles. - Cleaned and reorganized translations in multiple locales (English, Simplified/Traditional Chinese, Ukrainian, Russian, Literary Chinese, Japanese, Spanish, Arabic), dropping or shortening strings that are no longer used or are now centralized.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties | Adds new extension and *.add.title/world-add keys for Chinese (Simplified) and removes obsolete world/import-related labels to match new UI flow. |
| HMCL/src/main/resources/assets/lang/I18N_zh.properties | Same as zh_CN: updates Chinese (Traditional) strings for extensions and world/datapack/resourcepack/schematics add flows. |
| HMCL/src/main/resources/assets/lang/I18N_uk.properties | Cleans up unused installer/mod/datapack/world/schematics strings and adds new world-add error/chooser messages; relies more on English fallbacks for some labels. |
| HMCL/src/main/resources/assets/lang/I18N_ru.properties | Same pattern for Russian: adds world-add messages and datapack/world extension labels, removes old import/add strings now unused in code. |
| HMCL/src/main/resources/assets/lang/I18N_lzh.properties | Updates Literary Chinese extension/world-add/datapack-add texts and removes obsolete world import/extension keys. |
| HMCL/src/main/resources/assets/lang/I18N_ja.properties | Adjusts extension/world-add texts and removes older datapack/world import labels, aligning with the new “Add world” workflow. |
| HMCL/src/main/resources/assets/lang/I18N_es.properties | Spanish locale cleanup: introduces datapack/world extension and world-add messages; drops redundant installer/mod/datapack/world/schematics keys. |
| HMCL/src/main/resources/assets/lang/I18N_ar.properties | Arabic locale cleanup mirroring Spanish/Russian/Ukrainian: new extensions/world-add messages, old installer/mod/datapack/world/schematics strings removed. |
| HMCL/src/main/resources/assets/lang/I18N.properties | Centralizes new extension.* labels, shortens core toolbar labels (java.add, java.download, mods.add, etc.), introduces *.add.title and java.download.title, and simplifies some button texts. |
| HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/WorldListPage.java | Switches world file chooser and error dialogs from world.import.*/world.extension to new world.add.* and extension.world keys to match the new text scheme. |
| HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/SchematicsPage.java | Uses new schematics.add.title and extension.schematic for the add-schematics file chooser while keeping toolbar button text unchanged. |
| HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ResourcepackListPage.java | Uses resourcepack.add.title and extension.resourcepack for resource pack file chooser while retaining existing toolbar labels. |
| HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModListPage.java | Changes the mod file chooser title to mods.add.title and uses extension.mod for the filter, keeping toolbar and dialog headings on mods.add. |
| HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/InstallerListPage.java | Replaces the offline installer filter label with the generic extension.modloader.installer extension text. |
| HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/DatapackListPage.java | Updates datapack chooser title to datapack.add.title and filter to extension.datapack, matching the newly added localized strings. |
| HMCL/src/main/java/org/jackhuang/hmcl/ui/main/JavaDownloadDialog.java | Points dialog title and heading to java.download.title, leaving toolbar and task dialog captions on the shortened java.download label. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #4772