Skip to content

默认启用详细日志输出 #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Glavo merged 2 commits into from
Sep 14, 2025
Merged

默认启用详细日志输出 #12

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08dd123
默认启用详细日志输出
Glavo Sep 13, 2025
bc4e4bb
Merge remote-tracking branch 'upstream/main' into debug
Glavo Sep 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion HMCL/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
#include "java.h"

int APIENTRY wWinMain(HINSTANCE hInstance, HINSTANCE hPrevInstance, LPWSTR lpCmdLine, int nCmdShow) {
HLVerboseOutput = HLGetEnvVar(L"HMCL_LAUNCHER_VERBOSE_OUTPUT").value_or(L"") == L"true";
HLVerboseOutput = HLGetEnvVar(L"HMCL_LAUNCHER_VERBOSE_OUTPUT").value_or(L"") != L"false";
Copy link

Copilot AI Sep 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic change from opt-in to opt-out for verbose output could impact users who rely on the current quiet default behavior. Consider using a more explicit approach like checking for both 'true' and 'false' values, with a clear documented default, to make the behavior more predictable.

Suggested change
HLVerboseOutput = HLGetEnvVar(L"HMCL_LAUNCHER_VERBOSE_OUTPUT").value_or(L"") != L"false";
// Explicitly check for "true" or "1" (case-insensitive), default to false
auto verboseEnv = HLGetEnvVar(L"HMCL_LAUNCHER_VERBOSE_OUTPUT");
std::wstring verboseValue = verboseEnv.value_or(L"");
std::transform(verboseValue.begin(), verboseValue.end(), verboseValue.begin(), ::towlower);
HLVerboseOutput = (verboseValue == L"true" || verboseValue == L"1");

Copilot uses AI. Check for mistakes.

LPCWSTR javaExecutableName;
if (HLAttachConsole()) {
Expand Down