Skip to content

Conversation

@eduardo-rodrigues
Copy link
Member

@eduardo-rodrigues eduardo-rodrigues commented Oct 26, 2024

This is a follow-up from #1595 and #1599 to address trivial fixes for typos and to modify slightly the text as per community feedback.

Copy link
Member

@graeme-a-stewart graeme-a-stewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eduardo-rodrigues! I generally approve, but I have a wording suggestion for the versioning piece.

@eduardo-rodrigues eduardo-rodrigues marked this pull request as ready for review October 28, 2024 09:54
@graeme-a-stewart
Copy link
Member

pre-commit failure is a false positive, not relevant to this PR

@eduardo-rodrigues
Copy link
Member Author

Thanks for the quick reaction. Feel free to merge when OKed since I won't be able to later this week (cf. my private message to you).

@graeme-a-stewart
Copy link
Member

Yep, LGTM! Plus Valentin just fixed the spelling false alarm

@graeme-a-stewart graeme-a-stewart merged commit 117198e into main Oct 28, 2024
2 of 3 checks passed
@graeme-a-stewart graeme-a-stewart deleted the eduardo-affiliated-projs-update-1 branch October 28, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants