-
Notifications
You must be signed in to change notification settings - Fork 351
Issue #1696: Add mentors to metadata, generate mentor list automatically #1700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for earnest-hotteok-b1e1bf ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This is fantastic, thank you very much for this contribution! One small comment: names are unfortunately a bit complicated to handle, and here we have one case where the mentor has a last name and first name with whitespace. (First name: "John S." Last name: "De Stefano Jr." |
da804ac
to
6e1e0c9
Compare
…f.github.io into automated_mentors
Done My bad I made a mistake while resolving the conflict but now it is fixed |
- only generate mentor section in proposals from 2025 onwards. old projects do not have the metadata. - add is_preferred_contact that just prints the mentor in bold - change mentor.role to mentor.additional_information for more flexibility
I've added some small fixes, now this LGTM:
Your work was very easy to extend, thanks again for this nice contribution! |
Fixes #1696 |
PR Summary: