Skip to content

Conversation

MohanadKh03
Copy link
Contributor

PR Summary:

  • Mentor names are extracted automatically from the GSoC proposal pages from their front matter "YAML format"
  • The mentors are listed uniquely by their email on the mentors page

Copy link

netlify bot commented Feb 13, 2025

Deploy Preview for earnest-hotteok-b1e1bf ready!

Name Link
🔨 Latest commit 65e43eb
🔍 Latest deploy log https://app.netlify.com/sites/earnest-hotteok-b1e1bf/deploys/67b106962413980008e50890
😎 Deploy Preview https://deploy-preview-1700--earnest-hotteok-b1e1bf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MohanadKh03 MohanadKh03 changed the title gsoc: add mentors to metadata, generate mentor list automatically Issue #1696: Add mentors to metadata, generate mentor list automatically Feb 13, 2025
@vvolkl
Copy link
Contributor

vvolkl commented Feb 13, 2025

This is fantastic, thank you very much for this contribution!

One small comment: names are unfortunately a bit complicated to handle, and here we have one case where the mentor has a last name and first name with whitespace. (First name: "John S." Last name: "De Stefano Jr."
I'd suggest to just add a firstname and lastname field to the yaml header, like that you don't need to split the full name.

@vvolkl vvolkl added the GSoC Related to Google Summer of Code activity label Feb 14, 2025
@MohanadKh03
Copy link
Contributor Author

I'd suggest to just add a firstname and lastname field to the yaml header, like that you don't need to split the full name.

Done

My bad I made a mistake while resolving the conflict but now it is fixed

- only generate mentor section in proposals from 2025 onwards. old
  projects do not have the metadata.
- add is_preferred_contact that just prints the mentor in bold
- change mentor.role to mentor.additional_information for more
  flexibility
@vvolkl
Copy link
Contributor

vvolkl commented Feb 15, 2025

I've added some small fixes, now this LGTM:

  • mentor section in proposals from 2025 onwards. old
    projects do not have the metadata.
  • add is_preferred_contact that just prints the mentor in bold
  • change mentor.role to mentor.additional_information for more
    flexibility

Your work was very easy to extend, thanks again for this nice contribution!

@vvolkl
Copy link
Contributor

vvolkl commented Feb 15, 2025

Fixes #1696

@vvolkl vvolkl merged commit 9b4eb73 into HSF:main Feb 15, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSoC Related to Google Summer of Code activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants