feat: make excluded columns configurable in CollectionsInfoOverlay#775
Closed
Sai-Adithya-M wants to merge 1 commit intoHSF:mainfrom
Closed
feat: make excluded columns configurable in CollectionsInfoOverlay#775Sai-Adithya-M wants to merge 1 commit intoHSF:mainfrom
Sai-Adithya-M wants to merge 1 commit intoHSF:mainfrom
Conversation
Added excludeColumns Input to CollectionsInfoOverlayComponent to allow custom column exclusion. Updated changeCollection method to use the new input instead of a hardcoded list. Added unit test to verify the behavior.
Collaborator
|
The linting error probably just need |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Validation
[x] Code fulfills the rules in CONTRIBUTING.md
[x]test:ci passed (locally)
What:
This PR refactors CollectionsInfoOverlayComponent to allow the list of excluded columns in the collections info table to be configurable via an @input().
Why:
Previously, the list of excluded columns (['uuid', 'hits', 'isCut', 'labelText']) was hardcoded with a "FIXME" comment indicating it was an "ugly hack". Making this list configurable improves the reusability of the component and allows different contexts to exclude different columns as needed.
Changes
(defaulting to the original exclusion list).