Skip to content

fix(event-display): replace rainbow selection shader with glow outline#841

Closed
deveshbervar wants to merge 1 commit intoHSF:mainfrom
deveshbervar:fix/revert-rainbow-selection-effect
Closed

fix(event-display): replace rainbow selection shader with glow outline#841
deveshbervar wants to merge 1 commit intoHSF:mainfrom
deveshbervar:fix/revert-rainbow-selection-effect

Conversation

@deveshbervar
Copy link
Copy Markdown
Collaborator

Fixes #839

What this does

Replaces the animated rainbow selection shader with a clean golden glow outline, addressing the visual concern raised in #839.

Changes

  • Replaced SELECTION_FRAGMENT_SHADER rainbow animation with a solid golden pulse (vec3(1.0, 0.85, 0.3))
  • Replaced HOVER_FRAGMENT_SHADER static blue with a pulsing blue (vec3(0.3, 0.7, 1.0))
  • Removed unused RAINBOW_FUNCTION constant
  • Changed edge detection threshold to 1 for both hover and selection — removes the wireframe appearance

What is preserved from #721

  • Multi-object selection architecture
  • EdgesGeometry rendering (more efficient than the old OutlinePass)
  • Controls-based architecture
  • Double-click orbit targeting
  • Drag detection
  • Programmatic selection API

Note

Local build has a pre-existing BrowserslistError: Unknown version 146 of chrome issue on this machine unrelated to these changes.

@deveshbervar deveshbervar force-pushed the fix/revert-rainbow-selection-effect branch from 0d730fa to 43d7957 Compare March 20, 2026 11:29
@deveshbervar
Copy link
Copy Markdown
Collaborator Author

Hi @EdwardMoyse, this PR addresses #839.

Rather than a full revert, I kept the multi-selection architecture and performance improvements from #721 but made the following changes to effects-manager.ts:

  • Replaced the animated rainbow SELECTION_FRAGMENT_SHADER with a clean golden glow (vec3(1.0, 0.85, 0.3) with sine pulse)
  • Replaced the static HOVER_FRAGMENT_SHADER with a pulsing blue (vec3(0.3, 0.7, 1.0))
  • Removed the unused RAINBOW_FUNCTION constant
  • Changed edge detection threshold to 1 for both hover and selection — this removes the wireframe appearance

All interaction improvements from #721 are preserved (multi-selection, drag detection, double-click orbit, programmatic API).

Please let me know if you'd prefer a different color scheme or a full revert instead — happy to adjust!

@EdwardMoyse
Copy link
Copy Markdown
Collaborator

Argh. I'm sorry @deveshbervar - I had not realised that both you and @rx18-eng were working on similar topics. I'm really sorry about this - we should try not to overlap like this.

My comments to #837 apply here too - I definitely prefer the outline view. But interestingly, it seems like this is also not working on firefox / windows for me. So I am now wondering if this is caused by EdgesGeometry somehow, OR is specific to my computer at home.

image

@deveshbervar
Copy link
Copy Markdown
Collaborator Author

Thanks for the feedback @EdwardMoyse, no worries about the overlap!

I understand #837 is more comprehensive and closer to what you have in mind (true OutlinePass silhouette + pulsing animation + configurable color). Happy to close this PR in favour of #837 if that's the direction you want to go.

Alternatively, I can update this PR to also switch back to OutlinePass for true silhouette outlines with a pulsing animation — let me know which you prefer.

@EdwardMoyse
Copy link
Copy Markdown
Collaborator

@deveshbervar sorry again for the confusion, but I think you can close this one as I just merged #837

@deveshbervar
Copy link
Copy Markdown
Collaborator Author

No worries at all @EdwardMoyse! Happy to close this one.

At the end of the day we all want Phoenix to be better — glad #837 got the job done. Looking forward to contributing more!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possibly revert the rainbow selection effect

2 participants