fix(event-display): replace rainbow selection shader with glow outline#841
fix(event-display): replace rainbow selection shader with glow outline#841deveshbervar wants to merge 1 commit intoHSF:mainfrom
Conversation
0d730fa to
43d7957
Compare
|
Hi @EdwardMoyse, this PR addresses #839. Rather than a full revert, I kept the multi-selection architecture and performance improvements from #721 but made the following changes to
All interaction improvements from #721 are preserved (multi-selection, drag detection, double-click orbit, programmatic API). Please let me know if you'd prefer a different color scheme or a full revert instead — happy to adjust! |
|
Argh. I'm sorry @deveshbervar - I had not realised that both you and @rx18-eng were working on similar topics. I'm really sorry about this - we should try not to overlap like this. My comments to #837 apply here too - I definitely prefer the outline view. But interestingly, it seems like this is also not working on firefox / windows for me. So I am now wondering if this is caused by EdgesGeometry somehow, OR is specific to my computer at home.
|
|
Thanks for the feedback @EdwardMoyse, no worries about the overlap! I understand #837 is more comprehensive and closer to what you have in mind (true OutlinePass silhouette + pulsing animation + configurable color). Happy to close this PR in favour of #837 if that's the direction you want to go. Alternatively, I can update this PR to also switch back to OutlinePass for true silhouette outlines with a pulsing animation — let me know which you prefer. |
|
@deveshbervar sorry again for the confusion, but I think you can close this one as I just merged #837 |
|
No worries at all @EdwardMoyse! Happy to close this one. At the end of the day we all want Phoenix to be better — glad #837 got the job done. Looking forward to contributing more! |

Fixes #839
What this does
Replaces the animated rainbow selection shader with a clean golden glow outline, addressing the visual concern raised in #839.
Changes
SELECTION_FRAGMENT_SHADERrainbow animation with a solid golden pulse (vec3(1.0, 0.85, 0.3))HOVER_FRAGMENT_SHADERstatic blue with a pulsing blue (vec3(0.3, 0.7, 1.0))RAINBOW_FUNCTIONconstant1for both hover and selection — removes the wireframe appearanceWhat is preserved from #721
Note
Local build has a pre-existing
BrowserslistError: Unknown version 146 of chromeissue on this machine unrelated to these changes.