Prune deps #1286
Merged
Prune deps #1286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apollo client also has a dependency on it, and the types can and should be imported trough Apollo instead. Also the only piece of code that was referencing it was a piece of dead code that has been dropped completely. One might argue that the code was simply waiting to be used later on, but the implementation was not valid. GraphGL `variables` is not the correct way to passtrough the role into an Apollo query.
* Update both CommonJS and TypeScript plugins to lates versions. * Streamline bundles to index and CypressSpecExport. Aka, the seed data command bundles have been dropped, and the command have been included in the index bundle instead. * Changed packege.json commands to run the seed programs from the index.js file direcrtly. * Drop .d.ts file bundler, we can just reuse the files generated by tsc. * Add proper `exports` section to package.json.
Jontzii
approved these changes
Dec 4, 2025
Member
Jontzii
left a comment
Jontzii
left a comment
There was a problem hiding this comment.
@Jontzii reviewed 10 of 10 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Huulivoide)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI: Drop direct dep on
@graphql-typed-document-node/coreApollo client also has a dependency on it, and the types can and should be imported trough Apollo instead. Also the only piece of code that was referencing it was a piece of dead code that has been dropped completely. One might argue that the code was simply waiting to be used later on, but the implementation was not valid. GraphGL
variablesis not the correct way to passtrough the role into an Apollo query.UI: Drop unused deps: bufferutil, encoding & utf-8-validate
TDBM: Drop cross-fetch as unneeded
TDBM: Move rollup deps to devDependencies
TDBM: Update Rollup and streamline config
exportssection to package.json.This change is