Random changes #1314
Draft
Random changes #1314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dont set `addTypename` to `false` in unit tests when creating a Apollo MockProvider, its a boolean, so by practice the value is false by default. But primary reason for removal is that it is deprecated. In addition completely disable to broken deprecation warnings in test.
Instead of parsing the GraphQL queries on client side on every page
load, pre-generate the JS DocumentNodes into graphql.tsx
file.
Positive sides:
- Page load time is decreased as the page does not need to parse and
regenerate everysingle query on every single page load.
- Fixes duplicate fragment warnings, as we are no longer parsing
duplicate fragments (Next's tree shaking is not working).
- On IntellJ IDEA load times are much faster when the graphql.tsx
file changes, as IDEA does not have to parse each query.
Negatives:
- Larger file size, but difference is not too bad when the data is
compressed with brotli. Old 174K, new 179K
Dependency ReviewThe following issues were found:
OpenSSF Scorecard
Scanned Files
|
Huulivoide
force-pushed
the
reduce-warnings
branch
from
4d93099 to
b736b5e
Compare
* Define config variables in a single place. * Allow ovverriding build time config variables with a config file. * Generate a proper config file on Docker container startup.
Huulivoide
force-pushed
the
reduce-warnings
branch
from
b736b5e to
4d1e03c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is