Skip to content

Conversation

@suvikankare
Copy link
Member

@suvikankare suvikankare commented Jan 22, 2026

  • Linkittää tällä hetkellä itseensä, koska muutoshistoriasivua ei vielä ole olemassa. Tein kuitenkin valmiiks ni on sit helppo vaan vaihtaa kohde.
  • Testit: muokkauspäivämääräksi tulee testin alussa tämä hetki, ja koska testit menee niin nopeesti, edes minuutti ei ehdi vaihtua. Jotta sais testattua sen, että aika vaihtuu, pitäs pistää vähintään minuutin wait ja se tuntuu huonolta ajatukselta. Tähän saa antaa ehdotuksia jos on.
  • stopAreaDetails meni githubissa rikki ja korjaantu tyhjällä rivillä, who knows??? mutta siksi siellä on sellaset

This change is Reviewable

@github-actions
Copy link

github-actions bot commented Jan 22, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@suvikankare suvikankare changed the title Show update info quay DRAFT: Show update info in quay Jan 22, 2026
@suvikankare suvikankare force-pushed the show-update-info-quay branch 4 times, most recently from 0843c53 to f4ba52c Compare January 22, 2026 10:27
@suvikankare suvikankare changed the title DRAFT: Show update info in quay Show update info in quay Jan 22, 2026
@suvikankare suvikankare marked this pull request as ready for review January 22, 2026 10:41
@suvikankare suvikankare force-pushed the show-update-info-quay branch from f4ba52c to b84bc1d Compare January 22, 2026 11:07
Copy link
Contributor

@Huulivoide Huulivoide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Huulivoide reviewed 17 files and all commit messages, and made 3 comments.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @suvikankare).


ui/src/components/stop-registry/stops/queries/useGetQuayChangeHistory.ts line 9 at r1 (raw file):

const GQL_GET_QUAY_CHANGE_HISTORY = gql`
  query GetQuayChangeHistory($where: stops_database_quay_bool_exp) {

Sanoisin että where ehto on pakollinen eli ! loppuun.


ui/src/components/stop-registry/stops/queries/useGetQuayChangeHistory.ts line 23 at r1 (raw file):

const GQL_GET_LATEST_QUAY_CHANGE = gql`
  query GetLatestQuayChange($where: stops_database_quay_bool_exp) {

Sama


ui/src/components/stop-registry/stops/queries/useGetQuayChangeHistory.ts line 38 at r1 (raw file):

`;

export const useGetQuayChangeHistory = (where: StopsDatabaseQuayBoolExp) => {

Tääkin on varmaan asia mikä pitäs sopia kunnolla koodi tyyleihin, että miten funktiot määritellään. const+nuoli vai funktio avain sana ylätasolla.

@suvikankare suvikankare force-pushed the show-update-info-quay branch from b84bc1d to 70b7b12 Compare January 22, 2026 12:27
Copy link
Member Author

@suvikankare suvikankare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suvikankare made 3 comments.
Reviewable status: 15 of 17 files reviewed, 3 unresolved discussions (waiting on @Huulivoide).


ui/src/components/stop-registry/stops/queries/useGetQuayChangeHistory.ts line 9 at r1 (raw file):

Previously, Huulivoide (Jesse Jaara) wrote…

Sanoisin että where ehto on pakollinen eli ! loppuun.

Done.


ui/src/components/stop-registry/stops/queries/useGetQuayChangeHistory.ts line 23 at r1 (raw file):

Previously, Huulivoide (Jesse Jaara) wrote…

Sama

Done.


ui/src/components/stop-registry/stops/queries/useGetQuayChangeHistory.ts line 38 at r1 (raw file):

Previously, Huulivoide (Jesse Jaara) wrote…

Tääkin on varmaan asia mikä pitäs sopia kunnolla koodi tyyleihin, että miten funktiot määritellään. const+nuoli vai funktio avain sana ylätasolla.

Selvästi on vaikeuksia saada tää pysymään tuolla aivolohkossa, mutta kiltisti taas muutettu :D

@suvikankare suvikankare force-pushed the show-update-info-quay branch from 70b7b12 to 32c6ca9 Compare January 22, 2026 12:34
Copy link
Contributor

@Huulivoide Huulivoide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Huulivoide reviewed 2 files and all commit messages, and resolved 3 discussions.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @suvikankare).

@suvikankare suvikankare merged commit 6f51cc7 into main Jan 23, 2026
24 checks passed
@suvikankare suvikankare deleted the show-update-info-quay branch January 23, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants