-
Notifications
You must be signed in to change notification settings - Fork 0
Show update info in quay #1324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show update info in quay #1324
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
0843c53 to
f4ba52c
Compare
f4ba52c to
b84bc1d
Compare
Huulivoide
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Huulivoide reviewed 17 files and all commit messages, and made 3 comments.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @suvikankare).
ui/src/components/stop-registry/stops/queries/useGetQuayChangeHistory.ts line 9 at r1 (raw file):
const GQL_GET_QUAY_CHANGE_HISTORY = gql` query GetQuayChangeHistory($where: stops_database_quay_bool_exp) {
Sanoisin että where ehto on pakollinen eli ! loppuun.
ui/src/components/stop-registry/stops/queries/useGetQuayChangeHistory.ts line 23 at r1 (raw file):
const GQL_GET_LATEST_QUAY_CHANGE = gql` query GetLatestQuayChange($where: stops_database_quay_bool_exp) {
Sama
ui/src/components/stop-registry/stops/queries/useGetQuayChangeHistory.ts line 38 at r1 (raw file):
`; export const useGetQuayChangeHistory = (where: StopsDatabaseQuayBoolExp) => {
Tääkin on varmaan asia mikä pitäs sopia kunnolla koodi tyyleihin, että miten funktiot määritellään. const+nuoli vai funktio avain sana ylätasolla.
b84bc1d to
70b7b12
Compare
suvikankare
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@suvikankare made 3 comments.
Reviewable status: 15 of 17 files reviewed, 3 unresolved discussions (waiting on @Huulivoide).
ui/src/components/stop-registry/stops/queries/useGetQuayChangeHistory.ts line 9 at r1 (raw file):
Previously, Huulivoide (Jesse Jaara) wrote…
Sanoisin että where ehto on pakollinen eli
!loppuun.
Done.
ui/src/components/stop-registry/stops/queries/useGetQuayChangeHistory.ts line 23 at r1 (raw file):
Previously, Huulivoide (Jesse Jaara) wrote…
Sama
Done.
ui/src/components/stop-registry/stops/queries/useGetQuayChangeHistory.ts line 38 at r1 (raw file):
Previously, Huulivoide (Jesse Jaara) wrote…
Tääkin on varmaan asia mikä pitäs sopia kunnolla koodi tyyleihin, että miten funktiot määritellään. const+nuoli vai funktio avain sana ylätasolla.
Selvästi on vaikeuksia saada tää pysymään tuolla aivolohkossa, mutta kiltisti taas muutettu :D
70b7b12 to
32c6ca9
Compare
Huulivoide
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Huulivoide reviewed 2 files and all commit messages, and resolved 3 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @suvikankare).
This change is