Page weight sql queries 2025 #4143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync from Main
Sync from main
…mart/almanac.httparchive.org into page-weight-sql-queries-2025
catch up from main
…mart/almanac.httparchive.org into page-weight-sql-queries-2025
tunetheweb
reviewed
Sep 1, 2025
There was a problem hiding this comment.
Mostly LGTM. However with the move to JSON columns we can access fields directly (except when dashes are used, in which case need to use array-like accessors).
Also CrUX data is page-level. Just make sure that's what you want. And willing to live with some sites not having this.
Let me know when ready to merge.
simplify JSON access Co-authored-by: Barry Pollard <[email protected]>
I am ready from my side. |
tunetheweb
reviewed
Sep 1, 2025
Happy my end! |
|
Cheers @dwsmart . Excellent work as always. Feel free to open follow up PRs as necessary as the chapter progresses. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes progress on #4081
The SQL queries for the 2025 Page Weight Chapter