Skip to content

Resolved issue with is_lcp_statically_discoverable #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tunetheweb merged 3 commits into from
Nov 3, 2024
Merged

Resolved issue with is_lcp_statically_discoverable #148

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31cca2b
Resolved issue with is_lcp_statically_discoverable
kevinfarrugia Sep 25, 2024
2792b10
Merge branch 'main' into statically_discoverable
tunetheweb Oct 14, 2024
6b67d70
Merge branch 'main' into statically_discoverable
tunetheweb Nov 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/performance.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ function getRawLcpElement(rawDoc, lcpUrl) {
src = i.getAttribute('href');
}

return src == lcpUrl;
return new URL(src, location.href).href == lcpUrl;
});

// lcp_elem_stats will match the img, not the source.
Expand Down