Skip to content

No unnecessary escaping, but the necessary escaping yes #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tomayac wants to merge 2 commits into from
Closed

No unnecessary escaping, but the necessary escaping yes #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40a0e94
No unnecessary escaping
tomayac Mar 5, 2025
4b889a1
Add missing double-escape slah
tomayac Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/create-fugu-apis.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const checkURLConditions = (where, url, mimeType, responseBody) => {
// (https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/MIME_types#textjavascript).
if (
where === "JavaScript" &&
/\.m?js/.test(url) &&
/\\.m?js/.test(url) &&
mimeType.toLowerCase().endsWith("script")
) {
return true;
Expand Down
10 changes: 5 additions & 5 deletions dist/fugu-apis.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,7 @@ const patterns = {
chromeStatusID: 5739224579964928,
},
'Pointer Lock (unadjustedMovement)': {
regEx: /unadjustedMovement\s*\:\s*/g,
regEx: /unadjustedMovement\s*:\s*/g,
where: 'JavaScript',
supported: (async () =>
'HTMLParagraphElement' in self
Expand Down Expand Up @@ -486,7 +486,7 @@ const patterns = {
((await navigator.serviceWorker?.ready) || self.registration))(),
featureDetection: `(async () => 'serviceWorker' in navigator && 'pushManager' in (await navigator.serviceWorker?.ready || self.registration))()`,
documentation: 'https://developer.mozilla.org/en-US/docs/Web/API/Push_API',
blinkFeatureID: 769,
blinkFeatureID: 371,
Copy link
Member

@tunetheweb tunetheweb Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did this feature id change?

Copy link
Member Author

@tomayac tomayac Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yepp. A better one was found.

chromeStatusID: 5416033485586432,
},
'Relative Orientation Sensor': {
Expand Down Expand Up @@ -631,7 +631,7 @@ const patterns = {
chromeStatusID: 5662315307335680,
},
'Web Share Target (Files)': {
regEx: /"enctype"\s*\:\s*"multipart\/form\-data"/g,
regEx: /"enctype"\s*:\s*"multipart\/form-data"/g,
where: 'Web App Manifest',
supported: (async () => undefined)(),
featureDetection: `(async () => undefined)()`,
Expand Down Expand Up @@ -695,7 +695,7 @@ const patterns = {
chromeStatusID: 6261030015467520,
},
'WebOTP': {
regEx: /transport\s*\:\s*\[["']sms["']\]/g,
regEx: /transport\s*:\s*\[["']sms["']\]/g,
where: 'JavaScript',
supported: (async () => 'OTPCredential' in self)(),
featureDetection: `(async () => 'OTPCredential' in self)()`,
Expand Down Expand Up @@ -740,7 +740,7 @@ const patterns = {
chromeStatusID: 5651917954875392,
},
'Window Controls Overlay': {
regEx: /"window\-controls\-overlay"/g,
regEx: /"window-controls-overlay"/g,
where: 'Web App Manifest',
supported: (async () => 'windowControlsOverlay' in navigator)(),
featureDetection: `(async () => 'windowControlsOverlay' in navigator)()`,
Expand Down
8 changes: 4 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
},
"homepage": "https://github.com/HTTPArchive/custom-metrics#readme",
"devDependencies": {
"fugu-api-data": "^1.19.1",
"fugu-api-data": "^1.20.0",
"jest": "^29.7.0",
"webpagetest": "github:HTTPArchive/WebPageTest.api-nodejs"
},
Expand Down