Single js backend #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we even need Express? It looks like very simple servers and my understanding of the Node world (been a while since I really worked on this@) is that Node's built-in API have come on a lot, while Express has kinda stalled so you may not need Express. |
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the backend from legacy Python functions to a single JavaScript-based implementation, aiming for streamlined maintenance and improved performance.
- Removed all Python backend files (functions/categories and functions/adoption)
- Updated GitHub Actions pipeline to run Node.js commands and Terraform changes
- Revised README documentation to reflect the new endpoints and setup instructions
Reviewed Changes
Copilot reviewed 105 out of 105 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| functions/categories/requirements.txt | Removed legacy Python dependencies |
| functions/categories/main.py | Removed Python dispatcher function |
| functions/categories/libs/validator.py | Removed Python validation logic |
| functions/categories/libs/utils.py | Removed Python utility functions |
| functions/categories/libs/result.py | Removed Python result helper |
| functions/categories/libs/queries.py | Removed Python query implementation |
| functions/categories/libs/network.py | Removed Python network responders |
| functions/adoption/requirements.txt | Removed legacy Python dependencies |
| functions/adoption/main.py | Removed Python dispatcher function |
| functions/adoption/libs/validator.py | Removed Python validation logic |
| functions/adoption/libs/utils.py | Removed Python utility functions |
| functions/adoption/libs/result.py | Removed Python result helper |
| functions/adoption/libs/queries.py | Removed Python query implementation |
| functions/adoption/libs/network.py | Removed Python network responders |
| conftest.py | Removed Python test configurations |
| README.md | Updated documentation for the new Node.js backend and endpoints |
| .github/workflows/pipeline.yaml | Updated pipeline to run Node.js tests and adjusted Terraform parameters |
| .github/dependabot.yml | Added dependabot configuration for regular dependency updates |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend implementation as mentioned in HTTPArchive/httparchive.org#1048
Some enhancements:
ranksandgeosendpoints converted from hardcoded data to database queriesversionsendpointonlyname) will reduce payload sizes