Added Password Strength Checker (C++) for Better Security Awareness #197
Conversation
Added a C++ program that checks password strength based on standard security guidelines. This code helps users understand secure password practices — enhancing the project’s security awareness and practical coding examples.
…patch-1 Create SECURITY1.md
WalkthroughA new C++-like password strength checker demonstration is added to SECURITY1.md, implementing an Changes
Sequence DiagramsequenceDiagram
participant User
participant Program
participant isStrongPassword
User->>Program: Enters password
Program->>isStrongPassword: Calls with password string
activate isStrongPassword
isStrongPassword->>isStrongPassword: Check length ≥ 8
isStrongPassword->>isStrongPassword: Check for uppercase
isStrongPassword->>isStrongPassword: Check for lowercase
isStrongPassword->>isStrongPassword: Check for digit
isStrongPassword->>isStrongPassword: Check for special char
isStrongPassword-->>Program: Returns bool result
deactivate isStrongPassword
alt Password Strong
Program->>User: Print success message ✅
else Password Weak
Program->>User: Print warning message ⚠️
end
Program->>Program: Exit with code 0
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
SECURITY1.md (2)
7-20: Clarify special character validation logic.Line 16's
else hasSpecial = true;is overly broad—it treats any non-alphanumeric character (including whitespace, punctuation, symbols) as "special." For a security-focused password checker, consider being more explicit about what constitutes a valid special character (e.g.,!@#$%^&*). If this intentionally accepts any non-alphanumeric character for educational simplicity, add a clarifying comment.
22-34: Address input handling limitation:cin >> passwordonly reads single-word passwords.Line 25 uses
cin >> password, which stops at the first whitespace. This means passwords with spaces (e.g., "MyPass word123!") will only capture "MyPass," silently truncating the user input. For an educational example on security awareness, either:
- Add a comment explaining this limitation, or
- Use
getline(cin, password)to accept full-line input (handle newlines in the input buffer accordingly).Additionally, consider adding basic error handling after the
cinoperation to gracefully handle input failures.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
SECURITY1.md(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
SECURITY1.md
1-1: No space after hash on atx style heading
(MD018, no-missing-space-atx)
2-2: No space after hash on atx style heading
(MD018, no-missing-space-atx)
3-3: No space after hash on atx style heading
(MD018, no-missing-space-atx)
|
@japinderofficial-hub this is not required |
2 participants
🌟 Pre-submission Checklist
#pull-requestchannel to ensure no one else is working on this issue#pull-requestchannelSummary
Brief description of what this PR accomplishes.
Type of Changes
Testing Completed
Development Setup Verification
Code Quality
Related Issues
Closes #
Screenshots/Videos
Additional Notes
Any additional information or context about the changes.
Note: For faster PR review and approval, ensure you're active in our Discord server!
Summary by CodeRabbit