-
Notifications
You must be signed in to change notification settings - Fork 1
Add evening analysis quality validation framework with multi-language support and centralize news article CSS #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
12
commits into
main
Choose a base branch
from
copilot/enhance-news-analysis-testing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,731
−100
Draft
Changes from 5 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
d947ba4
Initial plan
Copilot 17843a9
feat: Add comprehensive test suite and validation for evening analysi…
Copilot e27822d
docs: Add comprehensive evening analysis documentation to WORKFLOWS.m…
Copilot 78d4f95
feat: Add news article styles to styles.css and update workflow to us…
Copilot e79e336
docs: Update all news workflows to use external CSS and follow style …
Copilot 63e5057
fix: Address PR review feedback for news-evening-analysis tests
Copilot 04f8a7d
fix: Address additional PR review feedback
Copilot c28f465
Merge branch 'main' into copilot/enhance-news-analysis-testing
pethers a96a865
fix: Complete truncated article titles in news index
Copilot aa2f84d
Merge branch 'main' into copilot/enhance-news-analysis-testing
pethers 4e9ca6c
Merge branch 'main' into copilot/enhance-news-analysis-testing
pethers bcf9de5
fix: Address 13 PR review issues - multi-language, accessibility, dat…
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hreflang example doesn’t note the repo’s Norwegian convention: article filenames use
-no.html, but hreflang should benb(Bokmål). Without calling this out, the workflow may generatehreflang="no", which would diverge from existing news article alternates. Consider explicitly including thenbalternate pointing to the-no.htmlfile in the template/example.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added documentation note in workflow: "Norwegian articles use filename suffix
-no.htmlbut hreflang codenb(Bokmål)" with explicit example showing all 14 languages. Commit: bcf9de5