DARYNA_TKACHENKO-w1-Node.js #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durw4rd
approved these changes
Nov 1, 2025
durw4rd
left a comment
durw4rd
left a comment
There was a problem hiding this comment.
Good job, Daryna - your work has all that was required. Great start before the second week :)
| const { cityName } = req.body; | ||
| if (!cityName) { | ||
| return res.status(400).send('Error: cityName is required in request body'); | ||
| } |
There was a problem hiding this comment.
Nice that you added validation of the payload 👍
durw4rd
reviewed
Nov 1, 2025
| }); | ||
|
|
||
| app.listen(PORT, () => { | ||
| console.log(`Server listening on http://localhost:${PORT}`); |
There was a problem hiding this comment.
It's perfectly fine to hardcode the domain in an exercise like this, but in situations where the app may run in environments other than locally, that should be avoided.
One option is to avoid mentioning the host: console.log(`Server listening on port ${PORT}`);
Alternatively, you can read it from the HOST environment variable: const HOST = process.env.HOST || 'localhost';
Author
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.