Majd hussein react w1 #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.2.11 to 5.4.6. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v5.4.6/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v5.4.6/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
JalalHabeeb
reviewed
Dec 22, 2025
JalalHabeeb
left a comment
JalalHabeeb
left a comment
There was a problem hiding this comment.
- The app is working, but as a React application, you should use states to switch the state of a component.
- The components folder should be inside the
srcfolder, where all other project files are. - The file name of a component should start with a Capital letter:
Category.tsx. It's not wrong if it's not, but it's preferred. - Mind the typos in the variable names. For example: button not buttun
| return; | ||
| } | ||
| buttunsArr.push(button); | ||
| console.log("button ++++", buttunsArr); |
There was a problem hiding this comment.
All console logs should be removed after finishing building the project.
week1/project/ecommerce/src/App.jsx
Outdated
|
|
||
| console.log("Buttons", CategoryBtn); | ||
| function App() { | ||
| const [count, setCount] = useState(0); |
JalalHabeeb
reviewed
Jan 6, 2026
JalalHabeeb
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://cold-meadow-ecfb.majdhussein144.workers.dev/