Mustafa Homsi #11
Open
Mustafa Homsi #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement login logic with user authentication and attempt tracking.
remarcmij
approved these changes
Jan 24, 2026
remarcmij
left a comment
remarcmij
left a comment
There was a problem hiding this comment.
Hi @homsi6313-art, the tasks are implemented correctly, but pay attention to detail. See my minor comments below. I'll approve your PR as-is.
Comment on lines
+12
to
+14
| console.log(`yes, ${year} is a leap year.`); | ||
| } else { | ||
| console.log(`no, ${year} is not a leap year.`); |
There was a problem hiding this comment.
Mind the casing:
Suggested change
| console.log(`yes, ${year} is a leap year.`); | |
| } else { | |
| console.log(`no, ${year} is not a leap year.`); | |
| console.log(`Yes, ${year} is a leap year.`); | |
| } else { | |
| console.log(`No, ${year} is not a leap year.`); |
Comment on lines
+11
to
+14
| const isAdmin = username == "admin" && password == "Hack1234"; | ||
| const isUser = username == "user" && password == "7654321"; | ||
|
|
||
| if (isAdmin || isUser) { |
There was a problem hiding this comment.
Use proper indentation, see https://hub.hackyourfuture.nl/Code-style-Basics-2b050f64ffc9807d912ed59b0c72440d
Suggested change
| const isAdmin = username == "admin" && password == "Hack1234"; | |
| const isUser = username == "user" && password == "7654321"; | |
| if (isAdmin || isUser) { | |
| const isAdmin = username == "admin" && password == "Hack1234"; | |
| const isUser = username == "user" && password == "7654321"; | |
| if (isAdmin || isUser) { |
| const eurAmount = usdAmountNum / EUR_USD_RATE; | ||
| console.log(usdAmountNum.toFixed(2) + ' USD is equal to ' + eurAmount.toFixed(2) + ' EUR.'); | ||
| } | ||
| }else if (menuSelection === "3") { |
There was a problem hiding this comment.
Suggested change
| }else if (menuSelection === "3") { | |
| } else if (menuSelection === "3") { |
| }else if (menuSelection === "3") { | ||
| console.log("Current exchange rate: 1 EUR = " + EUR_USD_RATE.toFixed(4) + " USD"); | ||
| } else { | ||
| console.log("Invalid selection. Please choose either 1 or 2."); |
There was a problem hiding this comment.
You added an option 3, but your error message only mentions 1 or 2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.