Mohammed A #12
Open
Mohammed A #12
+48
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remarcmij
requested changes
Jan 24, 2026
There was a problem hiding this comment.
Hi @mohammedalfakih-dev, thanks for your submission.In task-2 there is a simplication possible. Could you give it a try? The rest looks good. Actually, this duplication makes sense here.
task-1/leap-year.js
Outdated
| if (Number.isNaN(year) || year < 1 || year > 9999) { | ||
| console.log("Invalid year!"); | ||
| } else { | ||
| let isLeap = |
There was a problem hiding this comment.
- Prefer
constoverletif the variable does not need to be changed.
Suggested change
| let isLeap = | |
| const isLeap = |
- Best practice for JavaScript is to indent by 2 spaces (you are using 4 spaces here).
task-2/login.js
Outdated
Comment on lines
8
to
9
| errorMessage("Login blocked: Too many incorrect attempts."); | ||
| } else { |
There was a problem hiding this comment.
You can return early from the function if there are too many incorrect attempts. By doing so, you can get rid of the else statement:
Suggested change
| errorMessage("Login blocked: Too many incorrect attempts."); | |
| } else { | |
| errorMessage("Login blocked: Too many incorrect attempts."); | |
| return; | |
| } | |
| const isAdmin ... |
Author
|
hi, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.