Yusup R. #13
Open
Yusup R. #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remarcmij
approved these changes
Jan 24, 2026
remarcmij
left a comment
remarcmij
left a comment
There was a problem hiding this comment.
Hi @Yusuprozimemet, your PR looks good. One minor suggestion for task-1, but I will approve your PR now.
| return (y % 4 === 0 && y % 100 !== 0) || (y % 400 === 0); | ||
| } | ||
| return null; | ||
| }; |
There was a problem hiding this comment.
A function that starts with an is prefix is, by convention, expected to return a boolean. Your function however returns either a boolean or a null value. If you want to use functions for testing the year it would be better to create 2 functions, both returning booleans, each with a name that reflects their sole purpose.
- One for testing whether the year is valid.
- One for testing whether the year is a leap year.
For instance:
const isValidYear = (y) => y >= 1 && y <= 9999;
const isLeapYear = (y) => (y % 4 === 0 && y % 100 !== 0) || y % 400 === 0;| (username === correctUsername2 && password === correctPassword2) | ||
| ) { | ||
| successMessage('Logged in successfully!'); | ||
| incorrectAttempts = 0; // Reset on successful login |
There was a problem hiding this comment.
👍 for resetting the incorrect login count
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks are ready for review. thanks.