Skip to content

Conversation

@jesusoterogomez
Copy link
Contributor

@jesusoterogomez jesusoterogomez commented Nov 3, 2025

Main changes:

1. Updated session plan with two new sections:

  • Pull Requests (reminder to explain creating, reviewing, merging PRs). Useful for the exercises.
  • Forks

2. Breaks down exercise #1 into numbered steps

  • The instructions for exercise 1 were written in a conversational format. This PR changes it to follow the format of the rest of the exercises with a numbered list. To make it easier to follow.
  • Added a link to the README.md section of the hyf-assignment-template repo that explains how to create a PR to an own fork

Minor changes (unrelated):

  • removed note about central/individual repo approaches (I assume this is outdated content)
  • added small note about showing git add with all files vs. specific files. Trainees had issues with adding specific files during assignments due to not knowing they needed to type the entire path of the files.

- explain reviews/merging
- explain forking
- add link to guide on how to create PR against own fork
- add note to explain this is a repo that trainees will keep using
Comment on lines 90 to 92
14. Forks
- Your "copy" of a source repository
- How forks are useful for collaboration
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this, but I don't think this is high priority during the session.

An explanation is already linked here:
https://github.com/HackYourFuture-CPH/hyf-assignment-template?tab=readme-ov-file#about-this-repo

Copy link
Contributor

@adamblanchard adamblanchard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these changes 🙇

The linter is failing. If you run ./lint locally you'll be able to check yourself :)

After that, I'll approve and merge 🎉

@jesusoterogomez
Copy link
Contributor Author

jesusoterogomez commented Nov 4, 2025

@adamblanchard

Aww dang, I was SO sure I wasn't going to hit a linting issue. it's fixed now ✅

By the way, a super tiny detail:

Before running ./lint it seems we have to build the program at least once (npm run build) to get validateLinks.js in the dist directory

@adamblanchard
Copy link
Contributor

@jesusoterogomez haha it's a bet worth making.

Ah ok, I'll add it to the contributing guide at contributing/README.md, thanks for the heads up!

@jesusoterogomez
Copy link
Contributor Author

jesusoterogomez commented Nov 4, 2025

@adamblanchard
I'll get it right next time 🎰 💵

Also, I thought of that, but no need, I made this small edit to the linting script: #227

Copy link
Contributor

@shpomp shpomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@adamblanchard adamblanchard merged commit 1cbe905 into HackYourFuture-CPH:main Nov 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants