-
Notifications
You must be signed in to change notification settings - Fork 9
Foundation - Git - Add information about PRs and forks to session plan #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Foundation - Git - Add information about PRs and forks to session plan #225
Conversation
- explain reviews/merging - explain forking
- add link to guide on how to create PR against own fork - add note to explain this is a repo that trainees will keep using
| 14. Forks | ||
| - Your "copy" of a source repository | ||
| - How forks are useful for collaboration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this, but I don't think this is high priority during the session.
An explanation is already linked here:
https://github.com/HackYourFuture-CPH/hyf-assignment-template?tab=readme-ov-file#about-this-repo
adamblanchard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding these changes 🙇
The linter is failing. If you run ./lint locally you'll be able to check yourself :)
After that, I'll approve and merge 🎉
|
Aww dang, I was SO sure I wasn't going to hit a linting issue. it's fixed now ✅ By the way, a super tiny detail: Before running |
|
@jesusoterogomez haha it's a bet worth making. Ah ok, I'll add it to the contributing guide at contributing/README.md, thanks for the heads up! |
|
@adamblanchard Also, I thought of that, but no need, I made this small edit to the linting script: #227 |
shpomp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
Main changes:
1. Updated session plan with two new sections:
2. Breaks down
exercise #1into numbered stepsREADME.mdsection of thehyf-assignment-templaterepo that explains how to create a PR to an own forkMinor changes (unrelated):
git addwith all files vs. specific files. Trainees had issues with adding specific files during assignments due to not knowing they needed to type the entire path of the files.