Modules for team processes and career training #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…until we know more
…he split between specialisms
adamblanchard
changed the title
rvedotrc
reviewed
Apr 29, 2025
rvedotrc
reviewed
Apr 29, 2025
rvedotrc
reviewed
Apr 29, 2025
rvedotrc
reviewed
Apr 29, 2025
rvedotrc
reviewed
Apr 29, 2025
rvedotrc
reviewed
Apr 29, 2025
rvedotrc
approved these changes
Apr 29, 2025
Contributor
Author
|
@rvedotrc thanks for the review! I added parentheses for now (I think after we have all the new modules in place, we can do a final review of naming for consistency etc as well). Can we go for title case in the headers? I can update the other modules in another pr, but is it possible to add it as a linting rule? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further changes to move the proposal from this doc into github.
Check #36 for further context.
Most significant changes in here:
Both these modules' content hasn't been decided yet, in terms of splitting it between the courses. For now i'm proposing the strategy of "shared modules until they're not". In other words, keep it simple with one shared module until the content actually diverges between specialisms, then we can change it.