Fixed an issue with missing number casting in the import data script#269
Merged
Fixed an issue with missing number casting in the import data script#269
Conversation
HackYourFutures
temporarily deployed
to
dojo-import-script-fix-potmmui
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a type casting issue in the trainee data import script where cohort numbers were being sent as strings instead of numbers, causing API call failures. The changes convert CSV string values to numbers and relocate configuration constants for better organization.
Changes:
- Added Number.parseInt() calls to convert startCohort and currentCohort fields from strings to numbers
- Moved URL and TOKEN configuration constants to the top of the file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
stasel
force-pushed
the
import-script-fix
branch
from
5238e07 to
ac93d7a
Compare
HackYourFutures
temporarily deployed
to
dojo-import-script-fix-potmmui
Muatasim-Aswad
approved these changes
Jan 12, 2026
MBreathe
pushed a commit
to MBreathe/dojo
that referenced
this pull request
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This caused the POST /trainee API call to fail because the cohort number was from a string type and on the backend, it expects a number.