-
Notifications
You must be signed in to change notification settings - Fork 1
Add average test score to cohorts API and UI #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: stasel <[email protected]>
Co-authored-by: stasel <[email protected]>
… of undefined Co-authored-by: stasel <[email protected]>
|
Something is broken
Please check the endpoint again |
stasel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something is broken:
TypeError: Cannot read properties of undefined (reading 'calculateAverageTestScore')
Co-authored-by: stasel <[email protected]>
Fixed in commit 840b97f. The issue was that
Fixed in commit 840b97f. Added |
Co-authored-by: stasel <[email protected]>
9ddc192 to
1bc949d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds “average test score” to the cohorts API response and displays it in the Cohorts UI with color-coded styling.
Changes:
- Backend: select test scores in cohort trainee queries and compute
averageTestScoreper trainee. - Frontend: extend the cohorts model and render a new “Avg Test Score” column with threshold-based coloring.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| server/src/repositories/TraineesRepository.ts | Includes educationInfo.tests.score in the cohort query projection so scores are available for averaging. |
| server/src/controllers/CohortsController.ts | Adds averageTestScore to TraineeSummary and computes it from educationInfo.tests. |
| client/src/models/Cohorts.ts | Extends the client TraineeSummary model with averageTestScore. |
| client/src/components/cohorts/CohortAccordion.tsx | Adds a new table column to display the average score and color-codes it. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1bc949d to
7ee0c25
Compare
stasel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Teamwork
9cbd038 to
e9c8d5e
Compare
e9c8d5e to
9c06248
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
9c06248 to
5a56aa7
Compare
5a56aa7 to
ac50ae3
Compare
ac50ae3 to
0357263
Compare
zalexa19
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
Implementation Plan for Average Test Score Feature
TraineeSummaryinterface inCohortsController.tsto includeaverageTestScorepropertygetTraineeSummarymethod to compute average from test scoresTraineeSummaryinterface inCohorts.tsmodel to includeaverageTestScoreCohortAccordion.tsxOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.