refactor: centralize feature API calls#297
Merged
stasel merged 6 commits intoHackYourFuture:mainfrom Feb 9, 2026
Merged
Conversation
- Move cohorts, dashboard, search and trainee-profile HTTP calls into feature api/api.ts modules - Update React Query hooks to consume typed API helpers - Extract shared search response and trainee save request types Refs: HackYourFuture#287
Hadley99
requested review from
Aya-Alabrash,
sima-milli and
stasel
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements issue #287 by centralizing previously inline HTTP requests into feature-scoped api/api.ts modules and updating React Query hooks to call these typed API helpers.
Changes:
- Added per-feature
api/api.tsmodules for cohorts, dashboard, search, and trainee-profile subfeatures (personal info, interactions, tests, strikes). - Updated React Query hooks to use the new API helper functions instead of inline
axioscalls. - Extracted shared request/response types (e.g.,
SearchResultResponse,SaveTraineeRequestData) into dedicated type definitions.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| client/src/features/trainee-profile/personal-info/data/useTraineeInfoData.tsx | Refactors hooks to call getTraineeInfo/saveTraineeInfo and imports shared request type. |
| client/src/features/trainee-profile/personal-info/api/types.ts | Introduces SaveTraineeRequestData type for trainee profile saves. |
| client/src/features/trainee-profile/personal-info/api/api.ts | Adds typed API helpers for trainee info fetch/save. |
| client/src/features/trainee-profile/interactions/data/interaction-queries.ts | Updates interaction hooks to use centralized API helpers. |
| client/src/features/trainee-profile/interactions/api/api.ts | Adds interaction API helper functions and error handling. |
| client/src/features/trainee-profile/education/tests/data/test-queries.ts | Updates test hooks to use centralized API helpers. |
| client/src/features/trainee-profile/education/tests/api/api.ts | Adds tests API helper functions and error handling. |
| client/src/features/trainee-profile/education/strikes/data/strike-queries.ts | Updates strike hooks to use centralized API helpers. |
| client/src/features/trainee-profile/education/strikes/api/api.ts | Adds strikes API helper functions and error handling. |
| client/src/features/search/data/queries.ts | Refactors search query hook to use getSearchResults. |
| client/src/features/search/api/api.ts | Adds search API helper function. |
| client/src/features/search/Search.ts | Extracts SearchResultResponse type alongside SearchResult. |
| client/src/features/dashboard/data/useDashboardData.tsx | Refactors dashboard query hook to use getDashboardData. |
| client/src/features/dashboard/api/api.ts | Adds dashboard API helper function. |
| client/src/features/cohorts/data/useCohortsData.tsx | Refactors cohorts query hook to use getCohorts. |
| client/src/features/cohorts/api/api.ts | Adds cohorts API helper function. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
4 tasks
HackYourFutures
temporarily deployed
to
dojo-task-issue-287-cen-ttnydm
zalexa19
approved these changes
Feb 7, 2026
Contributor
zalexa19
left a comment
zalexa19
left a comment
There was a problem hiding this comment.
Dear Hadely,
The changes look good!
Thank you for your contribution :)
stasel
reviewed
Feb 7, 2026
HackYourFutures
temporarily deployed
to
dojo-task-issue-287-cen-ttnydm
stasel
approved these changes
Feb 8, 2026
Member
stasel
left a comment
stasel
left a comment
There was a problem hiding this comment.
Looks good. Can you please resolve all the comments? I will merge the PR after everything is resolved
Contributor
Author
@stasel , I've resolved all the comments. |
Member
|
Thank you for your contribution |
MBreathe
pushed a commit
to MBreathe/dojo
that referenced
this pull request
Feb 11, 2026
* refactor: centralize feature API calls - Move cohorts, dashboard, search and trainee-profile HTTP calls into feature api/api.ts modules - Update React Query hooks to consume typed API helpers - Extract shared search response and trainee save request types Refs: HackYourFuture#287 * Improved error handling * Removed try/catch to preserve 401 redirect functionality * improved parameter handling * refactor: streamline API response handling in trainee info functions * fixed params for axios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #287