Skip to content

Add new TestType enum values and update tests dropdown UI #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stasel merged 5 commits into from
Mar 2, 2026
Merged

Add new TestType enum values and update tests dropdown UI #310

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dfc9d37
Initial plan
Copilot Mar 2, 2026
ed2a70a
Add new TestType enum values to backend, frontend, and API docs
Copilot Mar 2, 2026
b0e3093
Address PR review comments: rename CoreEndInterview, fix api.yaml, sh…
Copilot Mar 2, 2026
ede348b
Fix MUI Select bugs: use arrays instead of fragments for conditional …
Copilot Mar 2, 2026
c4f4843
Simplify dropdown: always show only new test types, remove legacy con…
Copilot Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions client/src/data/types/Trainee.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,13 @@ export enum TestType {
NodeJS = 'nodejs',
ReactInterview = 'react-interview',
FinalProjectInterview = 'final-project-interview',
CoreMidTermInterview = 'core-mid-term-interview',
CoreEndTermInterview = 'core-end-interview',
Copy link
Member

@stasel stasel Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a mistake in the ticket, can you please rename the key to CoreEndInterview

Copy link
Contributor Author

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in b0e3093 — renamed to CoreEndInterview in both backend and frontend enums.

FrontEndMidTermInterview = 'frontend-mid-term-interview',
BackEndMidTermInterview = 'backend-mid-term-interview',
CloudMidTermInterview = 'cloud-mid-term-interview',
DataMidTermInterview = 'data-mid-term-interview',
TesterMidTermInterview = 'tester-mid-term-interview',
}

// interfaces
Expand Down
14 changes: 7 additions & 7 deletions client/src/features/trainee-profile/education/tests/TestDetailsModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,13 +134,13 @@ export const TestDetailsModal = ({
value={testFields.type ?? ''}
onChange={handleTestSelectChange}
>
<MenuItem value={TestType.Presentation}>Presentation</MenuItem>
<MenuItem value={TestType.JavaScript}>JavaScript</MenuItem>
<MenuItem value={TestType.BrowsersInterview}>Browsers interview</MenuItem>
<MenuItem value={TestType.UsingApisInterview}>Using APIs interview</MenuItem>
<MenuItem value={TestType.NodeJS}>Node.js</MenuItem>
<MenuItem value={TestType.ReactInterview}>React interview</MenuItem>
<MenuItem value={TestType.FinalProjectInterview}>Final project interview</MenuItem>
<MenuItem value={TestType.CoreMidTermInterview}>Core mid-term interview</MenuItem>
<MenuItem value={TestType.CoreEndTermInterview}>Core end-term interview</MenuItem>
Copy link
Member

@stasel stasel Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the caption to Core end interview

Copy link
Contributor Author

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in b0e3093 — caption is now Core end interview.

<MenuItem value={TestType.FrontEndMidTermInterview}>Frontend mid-term interview</MenuItem>
<MenuItem value={TestType.BackEndMidTermInterview}>Backend mid-term interview</MenuItem>
<MenuItem value={TestType.CloudMidTermInterview}>Cloud mid-term interview</MenuItem>
<MenuItem value={TestType.DataMidTermInterview}>Data mid-term interview</MenuItem>
<MenuItem value={TestType.TesterMidTermInterview}>Tester mid-term interview</MenuItem>
</Select>
{typeError && <FormHelperText>Type is required</FormHelperText>}
</FormControl>
Expand Down
7 changes: 7 additions & 0 deletions server/api.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1658,6 +1658,13 @@ components:
- nodejs
- react-interview
- final-project-interview
- core-mid-term-interview
- core-end-interview
- frontend-mid-term-interview
- backend-mid-term-interview
- cloud-mid-term-interview
- data-mid-term-interview
- tester-mid-term-interview
score:
type: number
example: 8.6
Expand Down
7 changes: 7 additions & 0 deletions server/src/models/Trainee.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,13 @@ export enum TestType {
NodeJS = 'nodejs',
ReactInterview = 'react-interview',
FinalProjectInterview = 'final-project-interview',
CoreMidTermInterview = 'core-mid-term-interview',
CoreEndTermInterview = 'core-end-interview',
FrontEndMidTermInterview = 'frontend-mid-term-interview',
BackEndMidTermInterview = 'backend-mid-term-interview',
CloudMidTermInterview = 'cloud-mid-term-interview',
DataMidTermInterview = 'data-mid-term-interview',
TesterMidTermInterview = 'tester-mid-term-interview',
}

export interface Trainee {
Expand Down