Textfield placeholders for edit mode only#312
Merged
MBreathe merged 4 commits intoHackYourFuture:mainfrom Mar 17, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Trainee Profile UI so placeholders are only shown while editing, adjusts Contact tab layout width to be fully responsive, and applies npm audit fix changes that update client/server lockfiles.
Changes:
- Make
TextFieldplaceholders conditional onisEditModeacross Personal, Employment, Education, and Contact tabs. - Fix Contact tab layout by changing fixed
90chwidths to100%. - Update dependencies via
npm audit fixinclient/package-lock.jsonandserver/package-lock.json.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
client/src/features/trainee-profile/personal-info/PersonalInfo.tsx |
Adds edit-mode-only placeholders for several personal info fields. |
client/src/features/trainee-profile/employment/EmploymentInfo.tsx |
Makes placeholders appear only in edit mode (incl. CV URL). |
client/src/features/trainee-profile/education/EducationInfo.tsx |
Adds edit-mode-only placeholders for mentor fields. |
client/src/features/trainee-profile/contact/ContactInfo.tsx |
Updates widths to 100% and makes placeholders edit-mode-only. |
client/package-lock.json |
Dependency updates from npm audit fix (notably rollup/minimatch/ajv). |
server/package-lock.json |
Dependency updates from npm audit fix (AWS SDK packages, minimatch/ajv, multer, etc.). |
Files not reviewed (1)
- client/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
stasel
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes placeholder values only visible when editing on multiple tabs across the Trainee Profile page. In addition, it fixes a styling bug for the Contact tab, where before the width was set to
90chand now it is more flexible and set to100%.IN ADDITION
(this was achieved by running
npm audit fixforclient/andserver/)This pull request updates several dependencies in the
client/package-lock.jsonfile, focusing mainly on upgrading therollupplatform-specific packages,minimatch, andajvto their latest versions. These updates primarily address security, compatibility, and stability improvements.Dependency upgrades:
Rollup platform-specific packages: Upgraded all
@rollup/rollup-*packages from version4.57.1to4.59.0, covering various platforms and architectures (e.g., Android, Darwin, Linux, Windows, FreeBSD, OpenBSD, OpenHarmony). This includes the addition of explicitlibcfields for Linux variants.Minimatch: Upgraded
minimatchin several places:3.1.2to3.1.5for dependencies under@eslint/config-array,@eslint/eslintrc, andeslint.9.0.5to9.0.9for the mainminimatchdependency, with a minor update to thebrace-expansiondependency.Ajv: Upgraded the
ajvJSON schema validator from6.12.6to6.14.0.