Skip to content

Textfield placeholders for edit mode only#312

Merged
MBreathe merged 4 commits intoHackYourFuture:mainfrom
MBreathe:bug/textfield-placeholders
Mar 17, 2026
Merged

Textfield placeholders for edit mode only#312
MBreathe merged 4 commits intoHackYourFuture:mainfrom
MBreathe:bug/textfield-placeholders

Conversation

@MBreathe
Copy link
Contributor

@MBreathe MBreathe commented Mar 5, 2026

This pull request makes placeholder values only visible when editing on multiple tabs across the Trainee Profile page. In addition, it fixes a styling bug for the Contact tab, where before the width was set to 90ch and now it is more flexible and set to 100%.

IN ADDITION
(this was achieved by running npm audit fix for client/ and server/)

This pull request updates several dependencies in the client/package-lock.json file, focusing mainly on upgrading the rollup platform-specific packages, minimatch, and ajv to their latest versions. These updates primarily address security, compatibility, and stability improvements.

Dependency upgrades:

  • Rollup platform-specific packages: Upgraded all @rollup/rollup-* packages from version 4.57.1 to 4.59.0, covering various platforms and architectures (e.g., Android, Darwin, Linux, Windows, FreeBSD, OpenBSD, OpenHarmony). This includes the addition of explicit libc fields for Linux variants.

  • Minimatch: Upgraded minimatch in several places:

    • From 3.1.2 to 3.1.5 for dependencies under @eslint/config-array, @eslint/eslintrc, and eslint.
    • From 9.0.5 to 9.0.9 for the main minimatch dependency, with a minor update to the brace-expansion dependency.
  • Ajv: Upgraded the ajv JSON schema validator from 6.12.6 to 6.14.0.

MBreathe added 3 commits March 5, 2026 12:41
added 1 package, and audited 2 packages in 793ms

1 package is looking for funding
  run `npm fund` for details

found 0 vulnerabilities for client/ and server/
Copilot AI review requested due to automatic review settings March 5, 2026 13:53
@MBreathe MBreathe linked an issue Mar 5, 2026 that may be closed by this pull request
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Trainee Profile UI so placeholders are only shown while editing, adjusts Contact tab layout width to be fully responsive, and applies npm audit fix changes that update client/server lockfiles.

Changes:

  • Make TextField placeholders conditional on isEditMode across Personal, Employment, Education, and Contact tabs.
  • Fix Contact tab layout by changing fixed 90ch widths to 100%.
  • Update dependencies via npm audit fix in client/package-lock.json and server/package-lock.json.

Reviewed changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
client/src/features/trainee-profile/personal-info/PersonalInfo.tsx Adds edit-mode-only placeholders for several personal info fields.
client/src/features/trainee-profile/employment/EmploymentInfo.tsx Makes placeholders appear only in edit mode (incl. CV URL).
client/src/features/trainee-profile/education/EducationInfo.tsx Adds edit-mode-only placeholders for mentor fields.
client/src/features/trainee-profile/contact/ContactInfo.tsx Updates widths to 100% and makes placeholders edit-mode-only.
client/package-lock.json Dependency updates from npm audit fix (notably rollup/minimatch/ajv).
server/package-lock.json Dependency updates from npm audit fix (AWS SDK packages, minimatch/ajv, multer, etc.).
Files not reviewed (1)
  • client/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MBreathe MBreathe merged commit 09b4959 into HackYourFuture:main Mar 17, 2026
1 check passed
@MBreathe MBreathe deleted the bug/textfield-placeholders branch March 17, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Textfield placeholders in non-edit mode

3 participants