Fix: Make CalendarIconProps.icon optional to prevent type error

[jingjing2222]

Summary

This fixes an issue where CalendarIconProps.icon became a required property, causing a type error.

Changes

• Changed CalendarIconProps.icon from required to optional using Partial.
• Updated related type definitions to ensure backward compatibility.
• Added tests to verify that the changes don't break existing functionality.

Testing

• Ran yarn test, and all tests passed.

Closed #5405

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.93%. Comparing base (8883ad1) to head (47e9062).
Report is 34 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5406   +/-   ##
=======================================
  Coverage   96.93%   96.93%           
=======================================
  Files          30       30           
  Lines        3324     3324           
  Branches     1408     1395   -13     
=======================================
  Hits         3222     3222           
- Misses        100      102    +2     
+ Partials        2        0    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jingjing2222]

The issue occurred because when CalendarIconProps.icon was picked using Pick(Type, "icon"), it became a required property. This was causing a type error, likely due to compatibility issues with React 18.3.1.

To resolve the issue, I made the icon property optional by using Partial, which fixed the error without breaking existing functionality.

Here’s the updated version with Partial:

Since the narrowing behavior in TypeScript 4.4 was updated, there seems to be some ambiguity in the inference process. To address this, we need to be more explicit in specifying the types.

[martijnrusschen]

you mentioned adding tests, can you add those here as well?

[jingjing2222]

To clarify, I didn't add any new tests. I simply ran yarn test. Sorry if that caused any confusion.
Here are the results.

---