Skip to content

Fix readOnly prop for a clearButton and inline calendare #5564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2025
Merged

Fix readOnly prop for a clearButton and inline calendare #5564

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d705ff
fix(readonly): hide clear button when set readOnly prop
SergeyKazarinov Apr 13, 2025
a902e60
fix(readOnly): disable click for inline calendar when set readOnly prop
SergeyKazarinov Apr 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,6 +659,7 @@ export default class DatePicker extends Component<
event?: React.MouseEvent<HTMLElement> | React.KeyboardEvent<HTMLElement>,
monthSelectedIn?: number,
) => {
if (this.props.readOnly) return;
if (this.props.shouldCloseOnSelect && !this.props.showTimeSelect) {
// Preventing onFocus event to fix issue
// https://github.com/Hacker0x01/react-datepicker/issues/628
Expand Down Expand Up @@ -829,6 +830,7 @@ export default class DatePicker extends Component<

// When checking preSelection via min/maxDate, times need to be manipulated via getStartOfDay/getEndOfDay
setPreSelection = (date?: Date | null): void => {
if (this.props.readOnly) return;
const hasMinDate = isDate(this.props.minDate);
const hasMaxDate = isDate(this.props.maxDate);
let isValidDateSelection = true;
Expand Down Expand Up @@ -1388,9 +1390,11 @@ export default class DatePicker extends Component<
clearButtonClassName = "",
ariaLabelClose = "Close",
selectedDates,
readOnly,
} = this.props;
if (
isClearable &&
!readOnly &&
(selected != null ||
startDate != null ||
endDate != null ||
Expand Down
Loading