🐛 Fix EndDatePicker selection range progress #5619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Undo the PR Hacker0x01#5503 as by default we preselect the selected date to other months also, as a result the linked PR will disturb the keyboard selection range
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5619 +/- ##
==========================================
- Coverage 96.98% 96.98% -0.01%
==========================================
Files 30 30
Lines 3355 3354 -1
Branches 1416 1415 -1
==========================================
- Hits 3254 3253 -1
Misses 101 101 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DawoudIO
added a commit
to ChurchCRM/CRM
that referenced
this pull request
Jul 7, 2025
 <h3>Snyk has created this PR to upgrade react-datepicker from 8.3.0 to 8.4.0.</h3> :information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project. <hr/> - The recommended version is **1 version** ahead of your current version. - The recommended version was released **a month ago**. <details> <summary><b>Release notes</b></summary> <br/> <details> <summary>Package name: <b>react-datepicker</b></summary> <ul> <li> <b>8.4.0</b> - <a href="https://redirect.github.com/Hacker0x01/react-datepicker/releases/tag/v8.4.0">2025-05-25</a></br><h2>What's Changed</h2> <ul> <li>Fix readOnly prop for a clearButton and inline calendare by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/SergeyKazarinov/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/SergeyKazarinov">@ SergeyKazarinov</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2991375173" data-permission-text="Title is private" data-url="Hacker0x01/react-datepicker#5564" data-hovercard-type="pull_request" data-hovercard-url="/Hacker0x01/react-datepicker/pull/5564/hovercard" href="https://redirect.github.com/Hacker0x01/react-datepicker/pull/5564">#5564</a></li> <li>Fix <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2999650705" data-permission-text="Title is private" data-url="Hacker0x01/react-datepicker#5573" data-hovercard-type="issue" data-hovercard-url="/Hacker0x01/react-datepicker/issues/5573/hovercard" href="https://redirect.github.com/Hacker0x01/react-datepicker/issues/5573">#5573</a> 🐛 Fix the Selected Year Picker style when no date is selected by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/balajis-qb/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/balajis-qb">@ balajis-qb</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="3006849862" data-permission-text="Title is private" data-url="Hacker0x01/react-datepicker#5584" data-hovercard-type="pull_request" data-hovercard-url="/Hacker0x01/react-datepicker/pull/5584/hovercard" href="https://redirect.github.com/Hacker0x01/react-datepicker/pull/5584">#5584</a></li> <li>Parse date range with dashes by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/alexz-sg/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/alexz-sg">@ alexz-sg</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="3002849585" data-permission-text="Title is private" data-url="Hacker0x01/react-datepicker#5578" data-hovercard-type="pull_request" data-hovercard-url="/Hacker0x01/react-datepicker/pull/5578/hovercard" href="https://redirect.github.com/Hacker0x01/react-datepicker/pull/5578">#5578</a></li> <li>Include SCSS files in exports by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/saltire/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/saltire">@ saltire</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2984074621" data-permission-text="Title is private" data-url="Hacker0x01/react-datepicker#5560" data-hovercard-type="pull_request" data-hovercard-url="/Hacker0x01/react-datepicker/pull/5560/hovercard" href="https://redirect.github.com/Hacker0x01/react-datepicker/pull/5560">#5560</a></li> <li>🐛 Add missing datepicker close call onPopperKeyDown event - to handle ESC keydown event outside the day component by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/balajis-qb/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/balajis-qb">@ balajis-qb</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="3055666607" data-permission-text="Title is private" data-url="Hacker0x01/react-datepicker#5621" data-hovercard-type="pull_request" data-hovercard-url="/Hacker0x01/react-datepicker/pull/5621/hovercard" href="https://redirect.github.com/Hacker0x01/react-datepicker/pull/5621">#5621</a></li> <li>🐛 Fix EndDatePicker selection range progress by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/balajis-qb/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/balajis-qb">@ balajis-qb</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="3054052205" data-permission-text="Title is private" data-url="Hacker0x01/react-datepicker#5619" data-hovercard-type="pull_request" data-hovercard-url="/Hacker0x01/react-datepicker/pull/5619/hovercard" href="https://redirect.github.com/Hacker0x01/react-datepicker/pull/5619">#5619</a></li> <li>Add Claude Code GitHub Workflow by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/martijnrusschen/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/martijnrusschen">@ martijnrusschen</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="3084187602" data-permission-text="Title is private" data-url="Hacker0x01/react-datepicker#5640" data-hovercard-type="pull_request" data-hovercard-url="/Hacker0x01/react-datepicker/pull/5640/hovercard" href="https://redirect.github.com/Hacker0x01/react-datepicker/pull/5640">#5640</a></li> <li>Move away from <a class="user-mention notranslate" data-hovercard-type="organization" data-hovercard-url="/orgs/import/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/import">@ import</a> by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/martijnrusschen/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/martijnrusschen">@ martijnrusschen</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2858784029" data-permission-text="Title is private" data-url="Hacker0x01/react-datepicker#5426" data-hovercard-type="pull_request" data-hovercard-url="/Hacker0x01/react-datepicker/pull/5426/hovercard" href="https://redirect.github.com/Hacker0x01/react-datepicker/pull/5426">#5426</a></li> <li>🐛 Apply --keyboard-selected to only if it's not already selected by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/balajis-qb/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/balajis-qb">@ balajis-qb</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="3089230056" data-permission-text="Title is private" data-url="Hacker0x01/react-datepicker#5651" data-hovercard-type="pull_request" data-hovercard-url="/Hacker0x01/react-datepicker/pull/5651/hovercard" href="https://redirect.github.com/Hacker0x01/react-datepicker/pull/5651">#5651</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/alexz-sg/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/alexz-sg">@ alexz-sg</a> made their first contribution in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="3002849585" data-permission-text="Title is private" data-url="Hacker0x01/react-datepicker#5578" data-hovercard-type="pull_request" data-hovercard-url="/Hacker0x01/react-datepicker/pull/5578/hovercard" href="https://redirect.github.com/Hacker0x01/react-datepicker/pull/5578">#5578</a></li> </ul> <p><strong>Full Changelog</strong>: <a class="commit-link" href="https://redirect.github.com/Hacker0x01/react-datepicker/compare/v8.3.0...v8.4.0"><tt>v8.3.0...v8.4.0</tt></a></p> </li> <li> <b>8.3.0</b> - <a href="https://redirect.github.com/Hacker0x01/react-datepicker/releases/tag/v8.3.0">2025-04-09</a></br><h2>What's Changed</h2> <ul> <li>🐛🎨 Apply the <code>--selected</code> class for the YearPicker when the <code>selectsMultiple</code> is enabled by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/balajis-qb/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/balajis-qb">@ balajis-qb</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2959609233" data-permission-text="Title is private" data-url="Hacker0x01/react-datepicker#5524" data-hovercard-type="pull_request" data-hovercard-url="/Hacker0x01/react-datepicker/pull/5524/hovercard" href="https://redirect.github.com/Hacker0x01/react-datepicker/pull/5524">#5524</a></li> <li>Fix <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2924009885" data-permission-text="Title is private" data-url="Hacker0x01/react-datepicker#5502" data-hovercard-type="issue" data-hovercard-url="/Hacker0x01/react-datepicker/issues/5502/hovercard" href="https://redirect.github.com/Hacker0x01/react-datepicker/issues/5502">#5502</a>: 🐛 Fix '--in-selecting-range' class apply condition for End Date Picker by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/balajis-qb/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/balajis-qb">@ balajis-qb</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2924034579" data-permission-text="Title is private" data-url="Hacker0x01/react-datepicker#5503" data-hovercard-type="pull_request" data-hovercard-url="/Hacker0x01/react-datepicker/pull/5503/hovercard" href="https://redirect.github.com/Hacker0x01/react-datepicker/pull/5503">#5503</a></li> <li>🎨🔨 Re-adjust the height of TimePicker on Calendar resize due to number of days by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/balajis-qb/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/balajis-qb">@ balajis-qb</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2975931816" data-permission-text="Title is private" data-url="Hacker0x01/react-datepicker#5539" data-hovercard-type="pull_request" data-hovercard-url="/Hacker0x01/react-datepicker/pull/5539/hovercard" href="https://redirect.github.com/Hacker0x01/react-datepicker/pull/5539">#5539</a></li> </ul> <p><strong>Full Changelog</strong>: <a class="commit-link" href="https://redirect.github.com/Hacker0x01/react-datepicker/compare/v8.2.1...v8.3.0"><tt>v8.2.1...v8.3.0</tt></a></p> </li> </ul> from <a href="https://redirect.github.com/Hacker0x01/react-datepicker/releases">react-datepicker GitHub release notes</a> </details> </details> --- > [!IMPORTANT] > > - Check the changes in this PR to ensure they won't cause issues with your project. > - This PR was automatically created by Snyk using the credentials of a real user. --- **Note:** _You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs._ **For more information:** <img src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiIzMzc0YWFkMi0wNzJhLTQyNDUtOTgzYi1mZjhmNzAyYWI2NjQiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6IjMzNzRhYWQyLTA3MmEtNDI0NS05ODNiLWZmOGY3MDJhYjY2NCJ9fQ==" width="0" height="0"/> > - 🧐 [View latest project report](https://app.snyk.io/org/dawoudio/project/e27b08aa-e5d2-4b10-8303-630a69d0b669?utm_source=github&utm_medium=referral&page=upgrade-pr) > - 📜 [Customise PR templates](https://docs.snyk.io/scan-using-snyk/pull-requests/snyk-fix-pull-or-merge-requests/customize-pr-templates?utm_source=&utm_content=fix-pr-template) > - 🛠 [Adjust upgrade PR settings](https://app.snyk.io/org/dawoudio/project/e27b08aa-e5d2-4b10-8303-630a69d0b669/settings/integration?utm_source=github&utm_medium=referral&page=upgrade-pr) > - 🔕 [Ignore this dependency or unsubscribe from future upgrade PRs](https://app.snyk.io/org/dawoudio/project/e27b08aa-e5d2-4b10-8303-630a69d0b669/settings/integration?pkg=react-datepicker&utm_source=github&utm_medium=referral&page=upgrade-pr#auto-dep-upgrades) [//]: # 'snyk:metadata:{"customTemplate":{"variablesUsed":[],"fieldsUsed":[]},"dependencies":[{"name":"react-datepicker","from":"8.3.0","to":"8.4.0"}],"env":"prod","hasFixes":false,"isBreakingChange":false,"isMajorUpgrade":false,"issuesToFix":[],"prId":"3374aad2-072a-4245-983b-ff8f702ab664","prPublicId":"3374aad2-072a-4245-983b-ff8f702ab664","packageManager":"npm","priorityScoreList":[],"projectPublicId":"e27b08aa-e5d2-4b10-8303-630a69d0b669","projectUrl":"https://app.snyk.io/org/dawoudio/project/e27b08aa-e5d2-4b10-8303-630a69d0b669?utm_source=github&utm_medium=referral&page=upgrade-pr","prType":"upgrade","templateFieldSources":{"branchName":"default","commitMessage":"default","description":"default","title":"default"},"templateVariants":[],"type":"auto","upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2025-05-25T12:21:10.113Z"},"vulns":[]}'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #5599
Description
As mentioned in the linked issue, one of my previous PRs #5503 is causing an issue in applying
--in-selecting-rangeover the hovered days.We by default pre-select a selected date on the other months also. As a result the same date on the other months will be programatically pre-selected (even-though we didn't hover or select) and we use the same state to know the date till we want to highlight. The same issue also exist for startDate picker also, when navigating to the previous months - as we pre-select the already selected dates for the other months. So, as a fix I undo my existing fix.
Contribution checklist