Skip to content

Conversation

balajis-qb
Copy link
Contributor

Closes #3797

Description

As mentioned in the linked issue, the screen readers is currently reading the week names header using the text we set instead of the aria-label.

image

Changes
I added aria-hidden="true" for all the week number headers and moved the aria-label to the separate sr-only span and added colheader role.

Contribution checklist

  • I have followed the contributing guidelines.
  • I have added sufficient test coverage for my changes.
  • I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

Copy link

codecov bot commented Jul 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.12%. Comparing base (e7e26d1) to head (dec68cc).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5731   +/-   ##
=======================================
  Coverage   97.12%   97.12%           
=======================================
  Files          30       30           
  Lines        3374     3374           
  Branches     1427     1423    -4     
=======================================
  Hits         3277     3277           
- Misses         95       97    +2     
+ Partials        2        0    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@martijnrusschen martijnrusschen merged commit ec4ce2c into Hacker0x01:main Jul 7, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accessibility issue - screen reader readout of "Su Mo Tu We Th Fr Sa"

2 participants