🐛 Configure esbuild-wasm initialize to use installed package version #5893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d esbuild-wasm version - Set the version to https://unpkg.com/esbuild-wasm@${version}/esbuild.wasm to avoid the version conflicts - Upgrade esbuild-wasm to 0.25.10
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5893 +/- ##
=======================================
Coverage 97.26% 97.26%
=======================================
Files 30 30
Lines 3443 3443
Branches 1439 1439
=======================================
Hits 3349 3349
Misses 94 94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@martijnrusschen, Could you please review and merge this fix PR. Currently the transpilation is failing because the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Configures esbuild-wasm’s initialize to load the WASM from a URL pinned to the installed package version, preventing mismatches between the JS wrapper and the WASM binary. Also upgrades esbuild-wasm to 0.25.10.
Problem
Using an unpinned
WASMURL could fetch a different version than the installedesbuild-wasmJS, causing runtime errors and version conflicts.Linked PR: #5865
Changes
Contribution checklist