Skip to content

Conversation

balajis-qb
Copy link
Contributor

@balajis-qb balajis-qb commented Sep 30, 2025

Description

Ensures the transpilation/loading indicator displays correctly when toggling between the TypeScript and JavaScript tabs in the docs-site, preventing the brief, misleading error flash.

Problem
On tab switch, the loading state wasn’t activated early enough and previous error state could render momentarily, causing a transient error display.

Changes

  • Fix the loading state
  • Update the error message properly on transpilation error

Screenshots

Current Issue
https://github.com/user-attachments/assets/1b95b6e2-3b0d-483a-aa88-1aa02d200c21

After the Fix
https://github.com/user-attachments/assets/3b0b723d-7601-47a8-aa64-ad38e885864d

Contribution checklist

  • I have followed the contributing guidelines.
  • I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

Copy link

codecov bot commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.26%. Comparing base (ac7bd94) to head (52dfc5e).
⚠️ Report is 28 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5894   +/-   ##
=======================================
  Coverage   97.26%   97.26%           
=======================================
  Files          30       30           
  Lines        3443     3443           
  Branches     1439     1454   +15     
=======================================
  Hits         3349     3349           
  Misses         94       94           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@martijnrusschen martijnrusschen merged commit a402024 into Hacker0x01:main Sep 30, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants