QuarterYearPicker: align selected styling with other pickers and fix multi-select highlighting #5972
+124
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ass to the selected element - Updated the `isSelectedQuarter` method to properly compare the selected quarter. - Introduced `isQuarterSelected` method to handle quarter selection logic. - Added a test to ensure the keyboard-selected class is not applied when the quarter is part of the selected date. Closes Hacker0x01#5970
- Introduced `isSelectQuarterInList` method to handle selection of multiple quarters. - Updated the rendering logic to apply the selected class based on the new method. - Added tests to verify correct application of the selected class for both single and multiple selected dates. Closes Hacker0x01#5971
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5972 +/- ##
=======================================
Coverage 97.29% 97.30%
=======================================
Files 30 30
Lines 3470 3482 +12
Branches 1472 1476 +4
=======================================
+ Hits 3376 3388 +12
Misses 94 94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked issues: #5970, #5971
Problem
showQuarterYearPicker, the selected quarter receives bothreact-datepicker__quarter-text--selectedandreact-datepicker__quarter-text--keyboard-selected, causing the keyboard style to override the selected style and diverge from other pickers.selectsMultiple, not all selected quarters consistently show thereact-datepicker__quarter-text--selectedstyle.Changes
react-datepicker__quarter-text--keyboard-selectedwhen a quarter is already selected, matching behavior of other picker modes.react-datepicker__quarter-text--selectedto every selected quarter, regardless of selection order.selectsMultiplequarter selection flows.These fixes are based on the latest commits addressing #5970 and #5971.
React-Datepicker-crafted-by-HackerOne.7.mp4