fix: prevent month view jump when selecting from second calendar in range mode #6103
+46
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ange mode
When using monthsShown={2} with selectsRange={true}, selecting a date
from the second calendar no longer causes the view to jump back to the
first month.
The previous fix for #5939 unconditionally reset monthSelectedIn to 0
on every update when selectsRange was true. This fix changes it to only
reset when the calendar opens (transitions from closed to open), which
preserves the #5939 fix while allowing normal interaction with the
second calendar.
Fixes #5275
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>
martijnrusschen
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6103 +/- ##
=======================================
Coverage 99.23% 99.23%
=======================================
Files 30 30
Lines 3647 3651 +4
Branches 1574 1578 +4
=======================================
+ Hits 3619 3623 +4
Misses 27 27
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Hi @martijnrusschen, I Verified this fix. It's working good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using monthsShown={2} with selectsRange={true}, selecting a date from the second calendar no longer causes the view to jump back to the first month.
The previous fix for #5939 unconditionally reset monthSelectedIn to 0 on every update when selectsRange was true. This fix changes it to only reset when the calendar opens (transitions from closed to open), which preserves the #5939 fix while allowing normal interaction with the second calendar.
Fixes #5275