Add more audio banks and add some occasional mappings for audio macros#777
Conversation
gheskett
left a comment
gheskett
left a comment
There was a problem hiding this comment.
After some additional profiling, adding all 6 channels here seems to add up to potentially a couple hundred us of additional audio processing. It's not significant enough for me to outright deny this, but I am still hesitant to press the merge button unless people think it's a worthy sacrifice. (Admittedly idk why it's even that much; I thought the idle audio changes should've covered almost all of the additional overhead...)
|
You know what, nevermind; most of that seems like perf lotto of some sort (idk what else it could be). It's weird because code size should have decreased in this PR (apart from the 00_sound_player.s) so idk why this got such a bad dice roll. EDIT: I'm dumb it probably still technically increased. But even still it should be completely insignificant. |
#777) * Add more audio banks and add some occasional mappings for audio macros * Remove config define for extra sound banks --------- Co-authored-by: gheskett <gheskett@gmail.com>
2 participants
This change by arctic makes it easier to add SFX by adding extra audio channels for general use as well as opening up space in 00_sound_banks. It was an old commit lost to time and I think that shouldn't be the case since it makes adding SFX significantly less CBT